A user can request a single movie multiple times with auto-approve

[wastingaeons]

Describe the bug
A user with auto-approve movie can create duplicate requests. Does not appear to affect auto-approve TV nor requests needing admin approval.

What version of Overseerr are you running?
develop-2bfab5e99c04709a1ed45bf30748e4fb5ac95f72

To Reproduce

1. On discover or search page hover and request a movie with auto-approve permissions.
2. Click on movie poster to go to details.
3. Hit back button in browser.
4. Observe you can hover over movie and request again.
5. Observe duplicates on /requests page

Expected behavior
Duplicates should not be allowed.

Screenshots

Desktop (please complete the following information):

• OS: Win10
• Browser: Chrome
• Version: 87

Smartphone (please complete the following information):

• Device: OnePlus 6T
• OS: Android 11
• Browser: Chrome
• Version: 87

[wastingaeons]

Issue persists as described on develop-a3fe4e6321c3480ac0463ed26e0d9be25d88352f

[sct]

Will take a look.

[TheCatLady]

Hi @wastingaeons, are you still experiencing this issue? I was investigating this just now but could not repro the problem.

[wastingaeons]

@TheCatLady I can replicate it consistently on Win10 Chrome & Edge on the latest dev (57c00c1). Strangely I can no longer repro from my phone's chrome.

capture.mp4

Here's a video of it in action in an incognito Chrome window.

[TheCatLady]

@wastingaeons Thanks for following up! I think that perhaps it's a browser caching issue, since we hide the request button when there is an existing request. In your video, you can also see it disappear and only reappear when you press "back."

That said, we shouldn't actually add a duplicate request if one already exists. I will take a look at this later today 🙂

[TheCatLady]

@wastingaeons Hi again, could you see if you're able to repro the issue in Incognito mode? Also, do you have Overseerr behind a reverse proxy? I've been discussing this with the other devs, and we suspect this is a browser caching issue of some sort.

[wastingaeons]

Yes, the video is from a fresh incognito window.

Aha! It is behind a reverse proxy and I am unable to repro from accessing Overseerr directly.

Edit: Reverse proxy is nginx with LS.io's Swag. Probably outside the scope of Overseer, but like you mentioned, OS shouldn't allow duplicates =)

[TheCatLady]

Aha! It is behind a reverse proxy and I am unable to repro from accessing Overseerr directly.

Ah, bingo! Closing this issue now since it is unrelated to Overseerr itself. Thanks again for the quick follow-up responses!

[TheCatLady]

Yes, the video is from a fresh incognito window.

Aha! It is behind a reverse proxy and I am unable to repro from accessing Overseerr directly.

Edit: Reverse proxy is nginx with LS.io's Swag. Probably outside the scope of Overseer, but like you mentioned, OS shouldn't allow duplicates =)

We actually already added a check to prevent duplicates, but I think that your reverse proxy may be causing issues and preventing the initial request from going through immediately. I am also using SWAG but could not reproduce the problem. I suggest checking your SWAG and Overseerr proxy configurations, and seeking help from the appropriate support channels for SWAG if you still experience issues.