feat: lookup movie by imdbid if tmdbid does not exits for plex movie agent #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sct
reviewed
Jan 21, 2021
| imdbId: newMedia.imdbId, | ||
| }); | ||
| newMedia.tmdbId = tmdbMovie.id; | ||
| } |
There was a problem hiding this comment.
What about one more check following this to make sure we actually got the tmdb id? Just in case we couldn't find a match for some reason?
There was a problem hiding this comment.
Added code to throw error in case tmdb id is still unknown after these checks.
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case movie for Plex movie agent library does not have tmdbid - try looking it up by imdbid.
Screenshot (if UI related)
No UI changed
Todos
yarn buildyarn i18n:extractIssues Fixed or Closed by this PR
afaik, no issue for this