Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): handle empty array of media attributes #922

Merged
merged 2 commits into from Feb 12, 2021

Conversation

danshilm
Copy link
Collaborator

@danshilm danshilm commented Feb 12, 2021

Description

Small bugfix to correctly handle an empty array of movie/show attributes.
Also includes a modification to the i18n script to use escaped double apostrophes instead of single un-escaped ones.

Screenshot (if UI related)

N/A

Todos

  • Sucessfully builds yarn build

Issues Fixed or Closed by this PR

  • Fixes none

Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sct sct merged commit 04fa9f7 into sct:develop Feb 12, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants