Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for older versions of Android #590

Closed
wants to merge 1 commit into from
Closed

Add support for older versions of Android #590

wants to merge 1 commit into from

Conversation

oleavr
Copy link
Contributor

@oleavr oleavr commented May 17, 2021

Where getifaddrs() isn't available.

@tuexen
Copy link
Member

tuexen commented May 17, 2021

Just curious: Are you actually using a native SCTP stack on the mobile platforms?

@oleavr
Copy link
Contributor Author

oleavr commented May 17, 2021

Just curious: Are you actually using a native SCTP stack on the mobile platforms?

Yeah we need to be able to interop with WebRTC data channels in Frida – using libnice to implement ICE, GLib / glib-networking for DTLS, and this awesome library for the SCTP layer 🙂

Where getifaddrs() isn't available.
@tuexen
Copy link
Member

tuexen commented May 17, 2021

Just curious: Are you actually using a native SCTP stack on the mobile platforms?

Yeah we need to be able to interop with WebRTC data channels in Frida – using libnice to implement ICE, GLib / glib-networking for DTLS, and this awesome library for the SCTP layer 🙂

But this mans you don't need support for SCTP over IP. You just need support for running it over some lower layer. so you don't need to define INET or INET6... Doesn't this already solve your problem?

@oleavr
Copy link
Contributor Author

oleavr commented May 17, 2021

Just curious: Are you actually using a native SCTP stack on the mobile platforms?

Yeah we need to be able to interop with WebRTC data channels in Frida – using libnice to implement ICE, GLib / glib-networking for DTLS, and this awesome library for the SCTP layer 🙂

But this mans you don't need support for SCTP over IP. You just need support for running it over some lower layer. so you don't need to define INET or INET6... Doesn't this already solve your problem?

Ooh right, good point! So I suppose this PR doesn't make any sense as presumably that entire feature would be broken without getifaddrs(), and an actually useful PR would be one that implements a fallback. (And until somebody needs that ISTM it's better that the build fails than building cleanly with the SCTP over IP feature being broken, and only discovering that much later, at runtime.)

Sorry for the noise, and thanks a lot for clarifying! 😅

@oleavr oleavr closed this May 17, 2021
@oleavr oleavr deleted the old-android branch May 17, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants