-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Object(...) is not a function in ngx-color.js:895 #128
Comments
What version of rxjs do you have? |
Good question, I didn't installed rxjs directly to this project, because it's a tiny hobby one that I'm testing, but yeah, I didn't tried to npm install rxjs directly, but it is inside my node_modules, so I thought that your package required it directly... The on inside my node_modules is rxjs@5.5.8 |
you'll need rxjs > 6. Most angular library's list it as a peer dependency and it should show a warning on npm install. |
Looked here, yes, ionic does demand rxjs by itself, but an earlier version, that is why my rxjs is at v5.5.8... Looks like I have to wait for a new ionic release with rxjs v6 support, amirite? Do some earlier version of your ngx-color support rxjs<6? Thank your for your support |
Just checked here, looks like v1.2.1 supports rxjs@5.5.6, gonna try it out! |
So, I got it to work on 1.2.1 with "no errors", but can't drag the sliders if I'm mobile mode on chrome, I can only click inside the slider bar and then the slider jumps to the clicked position... Any ideas? =/ |
I've just released v2 which should solve mobile issues. However you would need rxjs 6. I think you could try |
Hey man, thanks again for your support, I tried ngx-color v2 with this specific version of rxjs and it worked, thanks! Now, I struggled trying to make the draggable items work on my iPhone, it seems to work only on my desktop browser... As I said, I'm using ionic, at this point I don't know who to blame, hahaha. Do you have any hint? Thanks again for your time! |
Does the demo work on your iphone? https://scttcper.github.io/ngx-color/ If it does it might be something with ionic |
How dumb was I... Should've tested the demo on my phone first hahaha! Yeah, it works really fine with the demo, gonna find a reason why ionic is maybe blocking some dragging related events. Thanks man, have a nice one! |
Hello there,
I am getting some errors with the basic implementation of this component.
I'm using:
First I tried
<color-slider></color-slider>
(with and withoutcolor
and(onChange)
set) and got an exception every time I clicked in the slider, and of course, couldn't drag the slider itself.Then I tried
<color-alpha-picker></color-alpha-picker>
, got the same exception that occurs in this part of the code (line 895 of ngx-color.js):It seems that
fromEvent
object is not defined.When I finally tried
<color-sketch></color-sketch>
I still got the same exception, but only when clicked in the two bottom sliders.Would love if you could give any hint to help me solve this problem.
Thanks in advance
The text was updated successfully, but these errors were encountered: