feat: rename default toastClass from .toast to .ngx-toastr #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: any styles for .toast will need to be renamed or pass `toastClass: 'toast'` to `ToastrModule.forRoot()`
trevor-hackett
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
I'm OK with the changes. Will maybe want to consider replacing old-toastr.css with the current toastr.css before the class name changes just in case there's need/demand to have the old class names for some reason.
You'll also want to update the README.md to indicate the correct default value of toastClass
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
golovlyev
pushed a commit
to Micord/ngx-toastr
that referenced
this pull request
Mar 13, 2020
) * feat: rename default toastClass from .toast to .ngx-toastr BREAKING CHANGE: any styles for .toast will need to be renamed or pass `toastClass: 'toast'` to `ToastrModule.forRoot()` * docs: update readme to match new default ngx-toastr (cherry picked from commit 4019e17) # Conflicts: # src/lib/toastr/toastr-config.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rename default toastClass from .toast to .ngx-toastr. All styles using
.toastwill need to be renamed or passtoastClass: 'toast'toToastrModule.forRoot()for legacy behaviorcloses #605
closes #602