Plugin "googleAnalytics" of type "undefined" is not found, can not store config #919
Comments
|
Oh my Scully config file BTW contains the following: import { getSitemapPlugin } from '@gammastream/scully-plugin-sitemap';
import { ScullyConfig, setPluginConfig } from '@scullyio/scully';
import { GoogleAnalytics } from '@scullyio/scully-plugin-google-analytics';
import { MinifyHtml } from 'scully-plugin-minify-html';
import { getTocPlugin, TocConfig, TocPluginName } from 'scully-plugin-toc';
import MermaidAPI from 'mermaid/mermaidAPI';
import { getMermaidPlugin, MermaidPluginName } from 'scully-plugin-mermaid';
/**
* configuration for the markdown plugin
*/
setPluginConfig('md', { enableSyntaxHighlighting: true });
/**
* configuration for the mermaid plugin
* All params as defined here are valid:
* https://mermaid-js.github.io/mermaid/getting-started/Setup.html#mermaidapi-configuration-defaults
*/
const mermaidOptions: MermaidAPI.Config = {
theme: 'dark',
};
const MermaidPlugin = getMermaidPlugin();
setPluginConfig(MermaidPlugin, mermaidOptions);
/**
* configuration for the sitemap plugin
*/
const SitemapPlugin = getSitemapPlugin();
setPluginConfig(SitemapPlugin, {
urlPrefix: 'https://d-koppenhagen.de',
sitemapFilename: 'sitemap.xml',
changeFreq: 'monthly',
priority: [
'1.0',
'0.9',
'0.8',
'0.7',
'0.6',
'0.5',
'0.4',
'0.3',
'0.2',
'0.1',
'0.0',
],
ignoredRoutes: [
/*'/404'*/
],
routes: {
'/': {
changeFreq: 'weekly',
priority: '1.0',
sitemapFilename: 'sitemap.xml',
},
'/blog/:slug': {
changeFreq: 'weekly',
priority: '0.9',
sitemapFilename: 'sitemap-blog.xml',
},
'/projects/:slug': {
changeFreq: 'weekly',
priority: '0.8',
sitemapFilename: 'sitemap-blog.xml',
},
},
});
/**
* configuration for the TOC plugin
*/
const tocOptions: TocConfig = {
blogAreaSelector: '.blog-content',
insertSelector: '#toc',
level: ['h2', 'h3'],
trailingSlash: true,
scrollIntoViewOnClick: true,
};
const TocPlugin = getTocPlugin();
setPluginConfig(TocPlugin, tocOptions);
/**
* Gtag plugin config
*/
setPluginConfig(GoogleAnalytics, { globalSiteTag: 'UA-XXXXXXXXX-X' });
/**
* configure defualt postRenderers
*/
const defaultPostRenderers = [GoogleAnalytics, MinifyHtml];
/**
* configuration for HTML minification plugin
*/
/**
* the actual scully configuration
*/
export const config: ScullyConfig = {
projectRoot: './src',
projectName: 'd-koppenhagen-website',
outDir: './dist/static',
defaultPostRenderers,
routes: {
'/projects/:slug': {
type: 'contentFolder',
slug: {
folder: './projects',
},
postRenderers: [MermaidPluginName, ...defaultPostRenderers],
},
'/blog/:slug': {
type: 'contentFolder',
postRenderers: [
TocPluginName,
MermaidPluginName,
...defaultPostRenderers,
],
slug: {
folder: './blog',
},
},
},
}; |
|
@d-koppenhagen I did some related changes that are in the latest beta (.6), can you give that a try and see if it persists? |
|
If I change this in my + "@scullyio/scully": "1.0.0-beta.6",
- "@scullyio/scully": "1.0.0-beta.5",... and run |
|
Ok, we will look futher into that, thanks for confirming |
|
@d-koppenhagen Do you continue with the same issue? |
|
Yep |
|
Tomorrow I will try to update all scully packages to the latest versions and then I can tell you if it still happens after updating to 1.0.0 |
|
Hey @jorgeucano , I juts update to scully version 1.0.0. Now the issue has gone away. I also notices that I added the GA plugin to the |
🐞 Bug report
When I will try to update some package in my Angular Scully project for my personal website (Repo here), the update is proceeded but there is a side effect that update also some part of the Scully plugin goolge analytics and the
package-lock.jsonfile is changed.Description
When I install all packages exactly as currently defined in the
packlage-lock.jsonfile, the scully plugin@scullyio/scully-plugin-google-analyticsworks (You can reproduce this by runningnpm cion the console as it will not update the lock file and it will install the exact locked versions. ✅But when I install the packages running
npm i, there is some update proceeded that causes the following error message on the console when runningnpm run scully:After the
npm iran, thepackage-lock.jsonfile contains the following change that causes the update and in fact the error when running Scully:🔬 Minimal Reproduction
npm inpm run scully:all(Or separate: an Angular Build, the Scully build)package-lock.jsonfile is adjusted and the Google Analytics plugin doesn't work anymore💻Your Environment
Angular Version:
Scully Version:
{ "name": "d-koppenhagen-website", "version": "0.0.0", "description": "d-koppenhagen.de website", "scripts": { "dev": "npm-run-all --parallel build:watch scully:watch", "release": "standard-version", "ng": "ng", "start": "ng serve", "build": "ng build", "build:watch": "ng build --watch", "test": "ng test", "lint": "ng lint", "e2e": "ng e2e", "scully": "scully", "scully:watch": "scully --watch", "scully:serve": "scully serve", "scully:all": "npm run build -- --prod && npm run scully -- --scanRoutes && npm run scully:serve", "post": "ng g @scullyio/init:post --metaDataFile='templates/blog-meta.yaml' --target='blog'", "project": "ng g @scullyio/init:post --metaDataFile='templates/project-meta.yaml' --target='projects'" }, "private": true, "author": "Danny Koppenhagen <mail@d-koppenhagen.de> (https://d-koppenhagen.de)", "homepage": "https://github.com/d-koppenhagen/d-koppenhagen-website", "bugs": { "url": "https://github.com/d-koppenhagen/d-koppenhagen-website/issues", "email": "mail@d-koppenhagen.de" }, "license": "SEE LICENSE IN LICENSE", "dependencies": { "@angular/animations": "~10.0.2", "@angular/cdk": "^10.0.1", "@angular/common": "~10.0.2", "@angular/compiler": "~10.0.2", "@angular/core": "~10.0.2", "@angular/forms": "~10.0.2", "@angular/platform-browser": "~10.0.2", "@angular/platform-browser-dynamic": "~10.0.2", "@angular/router": "~10.0.2", "@angular/service-worker": "~10.0.2", "@angular/youtube-player": "^10.0.0", "@fortawesome/angular-fontawesome": "^0.7.0", "@fortawesome/fontawesome-free": "^5.14.0", "@fortawesome/fontawesome-svg-core": "^1.2.30", "@fortawesome/free-brands-svg-icons": "^5.14.0", "@fortawesome/free-solid-svg-icons": "^5.14.0", "@ngneat/transloco": "^2.19.1", "@scullyio/ng-lib": "1.0.0-beta.2", "@scullyio/scully-plugin-google-analytics": "1.0.0-beta.0", "animate.css": "^4.1.0", "ng-navigator-share": "^1.0.4", "ng2-animate-on-scroll": "^2.0.0", "ngx-sharebuttons": "^8.0.1", "ngx-twitter-timeline": "^0.1.5", "prismjs": "^1.21.0", "rxjs": "~6.5.5", "tslib": "~2.0.0", "zone.js": "~0.10.3" }, "devDependencies": { "@angular-devkit/build-angular": "^0.1000.1", "@angular/cli": "~10.0.1", "@angular/compiler-cli": "~10.0.2", "@angular/language-service": "~10.0.2", "@commitlint/cli": "^9.1.2", "@commitlint/config-angular-type-enum": "^9.1.2", "@commitlint/config-conventional": "^9.1.2", "@gammastream/scully-plugin-sitemap": "1.0.4", "@scullyio/init": "1.0.0-beta.3", "@scullyio/scully": "1.0.0-beta.5", "@types/jasmine": "~3.5.11", "@types/jasminewd2": "~2.0.8", "@types/node": "^14.0.14", "codelyzer": "^5.2.2", "commitizen": "^4.2.1", "cz-conventional-changelog": "^3.3.0", "fast-xml-parser": "^3.17.4", "husky": "^4.2.5", "jasmine-core": "~3.5.0", "jasmine-spec-reporter": "~5.0.0", "jsdom": "^16.2.2", "karma": "~5.0.0", "karma-chrome-launcher": "~3.1.0", "karma-coverage-istanbul-reporter": "~3.0.2", "karma-jasmine": "~3.3.0", "karma-jasmine-html-reporter": "^1.5.0", "ngx-semantic-version": "^2.2.0", "npm-run-all": "^4.1.5", "prettier": "^2.1.1", "pretty-quick": "^3.0.0", "protractor": "~7.0.0", "scully-plugin-mermaid": "0.0.9", "scully-plugin-minify-html": "^3.2.0", "scully-plugin-toc": "^1.4.1", "standard-version": "^9.0.0", "ts-node": "~8.10.2", "tslint": "~6.1.0", "typescript": "~3.9.5" }, "husky": { "hooks": { "pre-commit": "pretty-quick --staged", "commit-msg": "commitlint -E HUSKY_GIT_PARAMS" } }, "config": { "commitizen": { "path": "./node_modules/cz-conventional-changelog" } } }🔥 Exception or Error
The text was updated successfully, but these errors were encountered: