Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More and improved samples and error messages #17

Merged
merged 1 commit into from
Dec 16, 2019
Merged

More and improved samples and error messages #17

merged 1 commit into from
Dec 16, 2019

Conversation

SanderElias
Copy link
Contributor

  • Updated the error messages in Scully-content to me more explanatory
  • updated the error for the missing during generation
  • updated demo plugin to extraRoutesPlugin to make it actually useful
  • reworked the home page to use the route for full/top-level routes list
    • this also uses the extraRoutesPlugin
  • added a top-level blog route that lists all the blogs

@jorgeucano jorgeucano self-requested a review December 16, 2019 10:49
@SanderElias SanderElias merged commit 33d298a into master Dec 16, 2019
@SanderElias SanderElias deleted the more-and-improved-samples.-improved-demo-plugin branch December 16, 2019 10:56
Jefiozie added a commit to Jefiozie/scully that referenced this pull request Feb 13, 2023
@Jefiozie
feat: add playwright plugin (scullyio#17)
9056eb1 
* feat: add playwright plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeucano jorgeucano jorgeucano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SanderElias @jorgeucano