Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScullyRoutesService #317

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix ScullyRoutesService #317

merged 2 commits into from
Feb 20, 2020

Conversation

mchl18
Copy link
Contributor

@mchl18 mchl18 commented Feb 19, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

ScullyRoutesService observables looking for property published instead of publish;

Issue Number: #316

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@claassistantio
Copy link

claassistantio commented Feb 19, 2020

CLA assistant check
All committers have signed the CLA.

@SanderElias
Copy link
Contributor

Ok, I looked into it. it is the schematics that are off.
I'm going to ask @jorgeucano to look at this PR, and merge it if he is Ok with it.

@SanderElias SanderElias requested review from jorgeucano and removed request for SanderElias February 19, 2020 17:16
@SanderElias
Copy link
Contributor

@mchl18 can you sign the CLA?

@mchl18
Copy link
Contributor Author

mchl18 commented Feb 19, 2020

@SanderElias I signed the CLA.

@jorgeucano jorgeucano merged commit 0d5ae34 into scullyio:master Feb 20, 2020
@mchl18 mchl18 deleted the fix-service branch June 23, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants