Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngLib(feat) manual Ready signaling #344

Merged
merged 12 commits into from
Mar 3, 2020
Merged

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Mar 2, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

No way to manually trigger "idle"

Issue Number: N/A

What is the new behavior?

A way to set manual idle triggering globally using the forRoot,
and a way to set it per Route, using scullyconfig like this:

    '/manualIdle': {
      type: 'default',
      manualIdleCheck: true,
    },

With this setting, the developer becomes responsible for triggering IdleMonitorService.fireManualMyAppReadyEvent() when the app is ready for rendering.

closes #345

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

provide way to do manually ready signalling
remove stale import
@SanderElias SanderElias changed the title (feat) ngLib manual Ready signaling WIP ngLib(feat) manual Ready signaling Mar 3, 2020
@SanderElias SanderElias changed the title WIP ngLib(feat) manual Ready signaling ngLib(feat) manual Ready signaling Mar 3, 2020
@jorgeucano jorgeucano self-requested a review March 3, 2020 17:45
Copy link
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit b7a4c8f into master Mar 3, 2020
@SanderElias SanderElias deleted the sander/manualIdleCheck branch March 3, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable manualIdleDetection per route, instead of only global
2 participants