-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngLib(feat) manual Ready signaling #344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide way to do manually ready signalling
remove stale import
SanderElias
changed the title
(feat) ngLib manual Ready signaling
WIP ngLib(feat) manual Ready signaling
Mar 3, 2020
create a defaultRoutePlugin. this helps if you want to do something special to a common route
SanderElias
changed the title
WIP ngLib(feat) manual Ready signaling
ngLib(feat) manual Ready signaling
Mar 3, 2020
This was referenced Mar 3, 2020
jorgeucano
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No way to manually trigger "idle"
Issue Number: N/A
What is the new behavior?
A way to set manual idle triggering globally using the forRoot,
and a way to set it per Route, using scullyconfig like this:
With this setting, the developer becomes responsible for triggering
IdleMonitorService.fireManualMyAppReadyEvent()
when the app is ready for rendering.closes #345
Does this PR introduce a breaking change?
Other information