Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write transferState data to separate JSON file #356

Merged
merged 7 commits into from
Mar 5, 2020

Conversation

SanderElias
Copy link
Contributor

When a route has a treansferstate, extract it, and render it into a separate file.
Updates the library to use this file

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

When a route has a treansferstate, extract it, and render it into a separate file. Updates the
library to use this file
Copy link
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM work fine in windows!

@SanderElias SanderElias merged commit c89076f into master Mar 5, 2020
@SanderElias SanderElias deleted the sander/jsonDataFiles branch March 5, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants