Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/improvements #380

Merged
merged 4 commits into from
Mar 13, 2020
Merged

Docs/improvements #380

merged 4 commits into from
Mar 13, 2020

Conversation

GuzmanPI
Copy link
Contributor

@GuzmanPI GuzmanPI commented Mar 13, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

Website improvements

What is the current behavior?

Docs' website content is missing styles

Issue Number: #377

What is the new behavior?

Improves the docs website's style

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jorgeucano Can you doublecheck the styling?

The MD do not convert the "```typescript" to span... so, we cant use this!
@jorgeucano
Copy link
Contributor

LGTM

@jorgeucano jorgeucano merged commit b62d084 into scullyio:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants