Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sander/fix637 #638

Merged
merged 2 commits into from
Jun 18, 2020
Merged

sander/fix637 #638

merged 2 commits into from
Jun 18, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Scully-content render plugin fails if there is no _ngcontent attribute on the tag

Issue Number: N/A

What is the new behavior?

It is now working as expected

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano jorgeucano merged commit 1c4f213 into main Jun 18, 2020
@jorgeucano jorgeucano deleted the sander/fix637 branch June 18, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scully fails to render route from component with no styles/styleUrls defined
2 participants