sander/LogWarnon404 #644
Merged
sander/LogWarnon404 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeucano
approved these changes
Jun 22, 2020
during GA it failed for the difference between scullyBlog and scully-blog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more way's to handle 404 pages.
the "old" way routes are handled is now the "baseOnly" option.
the default way will provide the 'index.html' for all routes in
scully.routes.jsonthen there is
index, that will provide the index.html for all missing routes.404does the same as index, but uses the 404.html page.and lastly, there is a
noneoption, where we leave the handling to the express server.added a test, and doesn't have breaking changes.
Also, it will help #641, where the option
404would now close the issue