Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from import * to aid V10 compatability (tslib issue) #695

Merged
merged 11 commits into from
Jul 6, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

doesn't work with ts-lib2

Issue Number: N/A

What is the new behavior?

Hope it will work with tslib 2

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano
Copy link
Contributor

Now schematics check:
If the angular version is >= 8, If 8 use the angular v8 lib... if > use the other... Is the same library for v9 and v10?

@SanderElias SanderElias merged commit 77ab46e into main Jul 6, 2020
@SanderElias SanderElias deleted the sander/moveToNamedImports branch July 6, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants