Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix/schematics): package.json generated scripts #785

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

johanchouquet
Copy link
Contributor

@johanchouquet johanchouquet commented Jul 24, 2020

Documentation is right (https://scully.io/docs/scully-cmd-line/) for v1.0.0-beta.0, and says --project as the right way to launch those 2 scripts.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

When adding scully capabilities (ng add @scullyio/init) to an existing Angular project (not default project) in a Nx mono-repo, when running npm run scully, it simply fails, because it tries to launch scully --projectName=<projectName>. Same for npm run scully:serve.

Issue Number: N/A

What is the new behavior?

It works as expected.

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

Tested on Angular 9.1.9 project on a Windows 10 machine.

Documentation is right (https://scully.io/docs/scully-cmd-line/) for v1.0.0-beta.0, and says "--project " as the right way to launch those 2 scripts.
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2020

CLA assistant check
All committers have signed the CLA.

@jorgeucano jorgeucano merged commit da46431 into scullyio:main Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants