Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sentry logs #792

Merged
merged 13 commits into from
Aug 5, 2020
Merged

feat: Sentry logs #792

merged 13 commits into from
Aug 5, 2020

Conversation

PatrickJS
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

no error logging for the cli or docs

Issue Number: N/A

What is the new behavior?

error logging for the docs and cli

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fixes #783

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple of questions left.

  1. Is the logging of errors optional in the CLI? I seem to have missed the option to opt-out
  2. There are a couple of calls that have the 'suppressError' option. That means the call will never fail. yet you have added the sentry stuff there.
  3. The key for sentry seems hardcoded in Scully? shouldn't we use an environment var or something?
  4. can you explain the flush in pluginwrap.ts? I think it's not needed. The pluginsError is an option that when set, the program exists. Normally it just ignores plugin errors and carries on. (perhaps handle the flush in 'launchedBrowser.ts` where the whole exit is handled?

@PatrickJS PatrickJS changed the title Sentry logs feat: Sentry logs Jul 30, 2020
@amycdurbin
Copy link

amycdurbin commented Aug 4, 2020

@aaronfrost should we make this mandatory?

@aaronfrost
Copy link
Contributor

@amycdurbin should we make WHAT mandatory? That they opt into errors? Yes. It is not required to get permission for errors (I was told by Patrick). It is, however, required to get permission for telemetry data. So these errors are not telemetry. So let's do it.

Also, let's get this merged already... I want to see the errors that the users are seeing. We are wasting daylight by not merging this PR. Get it done already.

@amycdurbin
Copy link

@amycdurbin should we make WHAT mandatory? That they opt into errors? Yes. It is not required to get permission for errors (I was told by Patrick). It is, however, required to get permission for telemetry data. So these errors are not telemetry. So let's do it.

Also, let's get this merged already... I want to see the errors that the users are seeing. We are wasting daylight by not merging this PR. Get it done already.

@SanderElias please see Frosty's response.

@SanderElias
Copy link
Contributor

@aaronfrost I'm pretty sure collecting any data (including errors) from a user's system goes right into GRPD.
Or at least it will be frowned upon, and lead to questions that are easily avoided.

@SanderElias SanderElias merged commit 7959e55 into main Aug 5, 2020
@SanderElias SanderElias deleted the feat-sentry branch August 5, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logrocket telemetry for Scully CLI
5 participants