Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sander/supportRawRoutes #845

Merged
merged 23 commits into from
Aug 13, 2020
Merged

sander/supportRawRoutes #845

merged 23 commits into from
Aug 13, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [ x] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

none

Issue Number: N/A

What is the new behavior?

Allows routes to have an outside source to use for puppeteer rendering. useful for getting external data/hosted pages into the generated pages. The page s responsible for triggering the AngularReady event. If it does not do that, it will wait for 25 seconds

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Don and others added 21 commits August 5, 2020 21:58
docs(docsWeb): add dark theme to nav-header, fix margins
88e8f7b 
Added a simpler way of switching the color theme of nav-header through an Input and CSS
variables.
Adjusted some margins which were cut off or squished.
docs(docsWeb): updated snapshots
5bad0e4
docs(docsWeb): add mobile styles, add landing page checks for langSelect
9ec1c4f 
Add mobile styles and menu logic.
Add checks for langSelect to default to a lang when none are
available, for example on the landing page.
docs(docsWeb): complete mobile styles for doc pages
a65ad32
docs(docsWeb): update snapshots
768a597
docs(docsWeb): merge main into mobile-styles
b32b90d
docs(docsWeb): update snapshots
436ba9e
docs(docsWeb): adjust .page-content padding
51f1f4a
docs(docsWeb): update snapshots
8baff28
docs(docsWeb): update showcase mobile styles
5ea5faf
docs(docsWeb): update snapshot
106b6e3
@SanderElias
docs(docsWeb): solved merge-conflicts and updated snapshots
f6e95f5
docs(docsWeb): fix merge conflict conflicts
cf310d6
docs(docsWeb): update snapshot
40931e2
docs(docsWeb): update snapshot
fc54f7c
@SanderElias
Merge branch 'main' of github.com:scullyio/scully into mobile-styles-…
36bbb9b 
…merged
@SanderElias
test(docsWeb): refactor(monorepo): updated snapshots, and updated dep…
622b098 
…endencies
@SanderElias
feat(scully): an option to use external sites as the ource for puppet…
ed10ced 
…eer.

this options enables you to get content of an external site. the page on the location should fire
off the AngularReady event when its idle
@SanderElias
Merge branch 'main' of github.com:scullyio/scully into sander/support…
1d41874 
…RawRoutes
@SanderElias
fix(docsWeb): remove files that leaked fom different branch
cc10361
@SanderElias
Delete bars-regular.svg
3d54b80 
leaked in file
@SanderElias SanderElias merged commit 66e0e8e into main Aug 13, 2020
@SanderElias SanderElias deleted the sander/supportRawRoutes branch August 13, 2020 15:39
@SanderElias SanderElias linked an issue Aug 13, 2020 that may be closed by this pull request
Create a way to fetch an 'external' site #847
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeucano jorgeucano jorgeucano approved these changes

@aaronfrost aaronfrost Awaiting requested review from aaronfrost

@PatrickJS PatrickJS Awaiting requested review from PatrickJS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a way to fetch an 'external' site
2 participants
@SanderElias @jorgeucano