Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scully): make slugs containing foreign chars works #863

Merged
merged 2 commits into from
Aug 21, 2020
Merged

fix(scully): make slugs containing foreign chars works #863

merged 2 commits into from
Aug 21, 2020

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Aug 21, 2020 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #861

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SanderElias SanderElias merged commit 40b6db0 into main Aug 21, 2020
@SanderElias SanderElias deleted the sander/fixSlugEncoding branch August 21, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeucano jorgeucano jorgeucano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double encoding for non-latin slugs
2 participants
@SanderElias @jorgeucano