Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 馃悰 add support for WSL 2 #918

Merged
merged 3 commits into from
Sep 11, 2020
Merged

fix: 馃悰 add support for WSL 2 #918

merged 3 commits into from
Sep 11, 2020

Conversation

jorgeucano
Copy link
Contributor

@jorgeucano jorgeucano commented Sep 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: #844

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to not warn if they followed instructions?

`);
}


(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning also pop's up if they configured it correctly, right?
I can live with that. Sort-of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not know if have chrome install or not, So, is a warning like the SSL warning

@jorgeucano jorgeucano merged commit ce14786 into main Sep 11, 2020
@jorgeucano jorgeucano deleted the WSL/support branch September 11, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants