Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): removeScriptPlugn(fix) make sure _all_ scripts are removed #935

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix(lib): removeScriptPlugn(fix) make sure _all_ scripts are removed #935

merged 1 commit into from
Sep 22, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Not all scripts are removed correctly

Issue Number: N/A

What is the new behavior?

All scripts are removed correctly

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

jorgeucano
jorgeucano approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 8976147 into main Sep 22, 2020
@SanderElias SanderElias deleted the sander/fixRemoveScripts branch September 22, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeucano jorgeucano jorgeucano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SanderElias @jorgeucano