BUILDBOT: Disable only lastexpress engine on PSP2 (Vita). #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests show that at least for now, it is enough to only disable lastexpress to keep executable size small enough to prevent crashes on startup. This might change again in the future.
|
OK. This looks good, and I broke the build of PSP2 anyway since the option I specified does not appear to exist in ./configure (at least currently). I should have realised that just bare "./configure" does the expected thing i.e. compiles on stable engines. Anyway, will merge this and update buildbot so the next nightly will run with this. @rsn8887 : One point though is we could do with code with objdump or similar to detect if the static build is close to the limit ... or we can fix this more permanently with either plugins implementation or split builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My own tests show that, at least for now, it is enough to only disable
lastexpress and keep the other unstable engines on Vita. This keeps the executable size small enough to prevent the size-related crash on startup. This might change again in the future.