New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILDBOT: Disable only lastexpress engine on PSP2 (Vita). #15

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@rsn8887
Contributor

rsn8887 commented Oct 10, 2018

My own tests show that, at least for now, it is enough to only disable
lastexpress and keep the other unstable engines on Vita. This keeps the executable size small enough to prevent the size-related crash on startup. This might change again in the future.

BUILDBOT: Disable only lastexpress engine on PSP2 (Vita).
Tests show that at least for now, it is enough to only disable
lastexpress to keep executable size small enough to prevent
crashes on startup. This might change again in the future.
@digitall

This comment has been minimized.

Show comment
Hide comment
@digitall

digitall Oct 10, 2018

Member

OK. This looks good, and I broke the build of PSP2 anyway since the option I specified does not appear to exist in ./configure (at least currently). I should have realised that just bare "./configure" does the expected thing i.e. compiles on stable engines.

Anyway, will merge this and update buildbot so the next nightly will run with this.

@rsn8887 : One point though is we could do with code with objdump or similar to detect if the static build is close to the limit ... or we can fix this more permanently with either plugins implementation or split builds.

Member

digitall commented Oct 10, 2018

OK. This looks good, and I broke the build of PSP2 anyway since the option I specified does not appear to exist in ./configure (at least currently). I should have realised that just bare "./configure" does the expected thing i.e. compiles on stable engines.

Anyway, will merge this and update buildbot so the next nightly will run with this.

@rsn8887 : One point though is we could do with code with objdump or similar to detect if the static build is close to the limit ... or we can fix this more permanently with either plugins implementation or split builds.

@digitall digitall merged commit d179397 into scummvm:buildbot Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment