Skip to content

Commit

Permalink
PSP2: Force fullscreen always on
Browse files Browse the repository at this point in the history
Windowed mode never worked correctly and is pointless since Vita
operating system doesn't have a window manager.
  • Loading branch information
rsn8887 committed Aug 18, 2019
1 parent b7c089f commit 073d833
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions backends/platform/sdl/psp2/psp2.cpp
Expand Up @@ -82,9 +82,8 @@ void OSystem_PSP2::initBackend() {
ConfMan.registerDefault("touchpad_mouse_mode", false);
ConfMan.registerDefault("frontpanel_touchpad_mode", false);

if (!ConfMan.hasKey("fullscreen")) {
ConfMan.setBool("fullscreen", true);
}
ConfMan.setBool("fullscreen", true);

This comment has been minimized.

Copy link
@criezy

criezy Aug 18, 2019

Member

Is that necessary? I would think that ConfMan.registerDefault("fullscreen", true); (a few lines above) and not being able to change it would be sufficient?

To be clear, this seems fine to me. I am just curious whether I am missing something and that is indeed necessary. But it cannot do any arm in any case.

This comment has been minimized.

Copy link
@rsn8887

rsn8887 Aug 19, 2019

Author Contributor

This change is needed. Without this, a user that has an old scummvm.ini config file, created with an older ScummVM version, where fullscreen is set to false, would see unintended behavior.


if (!ConfMan.hasKey("aspect_ratio")) {
ConfMan.setBool("aspect_ratio", false);
}
Expand Down Expand Up @@ -130,6 +129,8 @@ void OSystem_PSP2::initBackend() {
}

bool OSystem_PSP2::hasFeature(Feature f) {
if (f == kFeatureFullscreenMode)
return false;

This comment has been minimized.

Copy link
@bluegr

bluegr Aug 18, 2019

Member

Why false?

This comment has been minimized.

Copy link
@criezy

criezy Aug 18, 2019

Member

The documentation says this feature flag can be used to switch between windowed and fullscreen mode. Considering the commit message I am assuming the PSP2 cannot switch between the two and only supports being in fullscreen.

This comment has been minimized.

Copy link
@bluegr

bluegr Aug 18, 2019

Member

Ah, right. The feature name is a bit misleading

This comment has been minimized.

Copy link
@rsn8887

rsn8887 Aug 19, 2019

Author Contributor

You got it.

return (f == kFeatureKbdMouseSpeed ||
f == kFeatureJoystickDeadzone ||
f == kFeatureShader ||
Expand All @@ -142,6 +143,8 @@ void OSystem_PSP2::setFeatureState(Feature f, bool enable) {
case kFeatureTouchpadMode:
ConfMan.setBool("touchpad_mouse_mode", enable);
break;
case kFeatureFullscreenMode:
break;
default:
OSystem_SDL::setFeatureState(f, enable);
break;
Expand All @@ -153,6 +156,9 @@ bool OSystem_PSP2::getFeatureState(Feature f) {
case kFeatureTouchpadMode:
return ConfMan.getBool("touchpad_mouse_mode");
break;
case kFeatureFullscreenMode:
return true;
break;
default:
return OSystem_SDL::getFeatureState(f);
break;
Expand Down

0 comments on commit 073d833

Please sign in to comment.