SCUMM HE: Fixed initialization in Moonbase AI

scummvm · May 30, 2016 · 0b240ff · 0b240ff
1 parent c8f2898
commit 0b240ff
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/engines/scumm/he/moonbase/ai_main.cpp b/engines/scumm/he/moonbase/ai_main.cpp
@@ -2110,7 +2110,7 @@ int *AI::energizeTarget(int &targetX, int &targetY, int index) {
 								break;
 							}
 
-							testDist = ((((n - attempt) / n) * .5) + .5) * (getDistance(getHubX(nextUnit), getHubY(nextUnit), targetX, targetY) / .8);
+							testDist = (((((double)n - (double)attempt) / n) * .5) + .5) * (getDistance(getHubX(nextUnit), getHubY(nextUnit), targetX, targetY) / .8);
 							xPos = getHubX(nextUnit) + testDist * cos(degToRad(testAngle));
 							yPos = getHubY(nextUnit) + testDist * sin(degToRad(testAngle));
 						}

diff --git a/engines/scumm/he/moonbase/ai_targetacquisition.cpp b/engines/scumm/he/moonbase/ai_targetacquisition.cpp
@@ -320,6 +320,15 @@ void Sortie::printEnemyDefenses() {
 	}
 }
 
+Defender::Defender(AI *ai) : _ai(ai) {
+	_sourceX = _sourceY = 0;
+	_targetX = _targetY = 0;
+	_sourceUnit = 0;
+	_power = 0;
+	_angle = 0;
+	_unit = 0;
+}
+
 int Defender::calculateDefenseUnitPosition(int targetX, int targetY, int index) {
 	int currentPlayer = _ai->getCurrentPlayer();
 

diff --git a/engines/scumm/he/moonbase/ai_targetacquisition.h b/engines/scumm/he/moonbase/ai_targetacquisition.h
@@ -112,7 +112,7 @@ class Defender {
 	AI *_ai;
 
 public:
-	Defender(AI *ai) : _ai(ai) {}
+	Defender(AI *ai);
 	void setSourceX(int sourceX) { _sourceX = sourceX; }
 	void setSourceY(int sourceY) { _sourceY = sourceY; }
 	void setTargetX(int targetX) { _targetX = targetX; }

diff --git a/engines/scumm/he/moonbase/ai_traveller.cpp b/engines/scumm/he/moonbase/ai_traveller.cpp
@@ -46,6 +46,8 @@ Traveller::Traveller(AI *ai) : _ai(ai) {
 	_waterSourceY = 0;
 	_waterDestX = 0;
 	_waterDestY = 0;
+
+	_posX = _posY = 0;
 }
 
 Traveller::Traveller(int originX, int originY, AI *ai) : _ai(ai) {