SCI: Fix unnecessary copy of Common::String

scummvm · May 8, 2017 · 1392506 · 1392506
1 parent f8d4ffa
commit 1392506
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/engines/sci/resource.h b/engines/sci/resource.h
@@ -571,7 +571,7 @@ class ResourceManager {
 	 * Process wave files as patches for Audio resources.
 	 */
 	void readWaveAudioPatches();
-	void processWavePatch(ResourceId resourceId, Common::String name);
+	void processWavePatch(ResourceId resourceId, const Common::String &name);
 
 	/**
 	 * Applies to all versions before 0.000.395 (i.e. KQ4 old, XMAS 1988 and LSL2).

diff --git a/engines/sci/resource_audio.cpp b/engines/sci/resource_audio.cpp
@@ -196,7 +196,7 @@ void ResourceManager::addNewGMPatch(SciGameId gameId) {
 	}
 }
 
-void ResourceManager::processWavePatch(ResourceId resourceId, Common::String name) {
+void ResourceManager::processWavePatch(ResourceId resourceId, const Common::String &name) {
 	ResourceSource *resSrc = new WaveResourceSource(name);
 	Common::File file;
 	file.open(name);