Skip to content

Commit

Permalink
Revert "KYRA: Plug memory leak"
Browse files Browse the repository at this point in the history
This reverts commit 9909cc6.

This will likely cause invalid memory reads because it frees the last output
buffer which is used to keep files in memory. There is a possible memory leak
here, when the input data is not well formed. However, fixing this takes some
more effort than the solution in the reverted commit.
  • Loading branch information
Johannes Schickel committed May 15, 2016
1 parent 3664caa commit 18193d1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions engines/kyra/resource_intern.cpp
Expand Up @@ -1180,8 +1180,6 @@ Common::Archive *InstallerLoader::load(Resource *owner, const Common::String &fi
delete tmpFile;
tmpFile = 0;
}
delete[] outbuffer;
outbuffer = 0;
}

archives.clear();
Expand Down

0 comments on commit 18193d1

Please sign in to comment.