SCI: Add notes

scummvm · Oct 19, 2014 · 1860c21 · 1860c21
1 parent d3475fe
commit 1860c21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/engines/sci/engine/kfile.cpp b/engines/sci/engine/kfile.cpp
@@ -922,6 +922,8 @@ reg_t kRestoreGame(EngineState *s, int argc, reg_t *argv) {
 				// path is never followed in these two cases (restoring game from the menu, or restoring a game
 				// from the ScummVM launcher). Thus, we perform the calls to enable the menus ourselves here.
 				// These two are needed when restoring from the launcher
+				// FIXME: The original interpreter saves and restores the menu state, so these attributes
+				// are automatically reset there. We may want to do the same.
 				g_sci->_gfxMenu->kernelSetAttribute(257 >> 8, 257 & 0xFF, SCI_MENU_ATTRIBUTE_ENABLED, TRUE_REG);    // Sierra -> About Jones
 				g_sci->_gfxMenu->kernelSetAttribute(258 >> 8, 258 & 0xFF, SCI_MENU_ATTRIBUTE_ENABLED, TRUE_REG);    // Sierra -> Help
 				// The rest are normally enabled from room1::init

diff --git a/engines/sci/engine/savegame.cpp b/engines/sci/engine/savegame.cpp
@@ -844,6 +844,8 @@ bool gamestate_save(EngineState *s, Common::WriteStream *fh, const Common::Strin
 	if (voc)
 		voc->saveLoadWithSerializer(ser);
 
+	// TODO: SSCI (at least JonesCD, presumably more) also stores the Menu state
+
 	return true;
 }