Skip to content

Commit

Permalink
IMAGE: Allow Indeo4 transparency decoding in scalable videos
Browse files Browse the repository at this point in the history
y459.avi in Starship Titanic uses these two modes together, and
this appears to work fine.
  • Loading branch information
csnover committed Aug 25, 2017
1 parent 4a39f85 commit 2b46eda
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions image/codecs/indeo4.cpp
Expand Up @@ -761,11 +761,12 @@ int Indeo4Decoder::decodeTransparency() {
}
}

// FIXME: The transparency plane can be split, though it is not clear if
// this is in scalability mode, local decoding mode, or both. This adds
// complexity to the implementation, so avoid supporting unless it turns out
// to actually be necessary for correct decoding of game videos.
assert(!_ctx._isScalable);
// FIXME: The transparency plane can be split, apparently for local decoding
// mode (y459.avi in Titanic has the scalable flag and its transparency
// plane seems to be decoded successfully, so the split transparency plane
// does not seem to be related to scaling mode). This adds complexity to the
// implementation, so avoid supporting unless it turns out to actually be
// necessary for correct decoding of game videos.
assert(!_ctx._usesTiling);

assert(_surface.format.bytesPerPixel == 4);
Expand Down

0 comments on commit 2b46eda

Please sign in to comment.