Skip to content

Commit

Permalink
BUILD: Rename USE_TEXT_CONSOLE -> USE_TEXT_CONSOLE_FOR_DEBUGGER
Browse files Browse the repository at this point in the history
This reduces the similarity in name to the otherwise mostly
unrelated DISABLE_TEXT_CONSOLE #define.
  • Loading branch information
fingolfin committed May 25, 2011
1 parent 717a7ac commit 4b7f6df
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion backends/platform/ds/arm9/makefile
Expand Up @@ -245,7 +245,7 @@ ifdef USE_MAD
DEFINES += -DUSE_MAD
endif

DEFINES += -DREDUCE_MEMORY_USAGE -DDISABLE_DEBUGGER -DUSE_TEXT_CONSOLE -DDISABLE_MASS_ADD -DDISABLE_NES_APU
DEFINES += -DREDUCE_MEMORY_USAGE -DDISABLE_DEBUGGER -DUSE_TEXT_CONSOLE_FOR_DEBUGGER -DDISABLE_MASS_ADD -DDISABLE_NES_APU

LDFLAGS = -specs=ds_arm9.specs -mthumb-interwork -mno-fpu -Wl,-Map,map.txt -Wl,--gc-sections

Expand Down
2 changes: 1 addition & 1 deletion configure
Expand Up @@ -2869,7 +2869,7 @@ if test "$_readline" = yes ; then
fi
define_in_config_h_if_yes "$_readline" 'USE_READLINE'

define_in_config_h_if_yes "$_text_console" 'USE_TEXT_CONSOLE'
define_in_config_h_if_yes "$_text_console" 'USE_TEXT_CONSOLE_FOR_DEBUGGER'

#
# Check for OpenGL (ES)
Expand Down
18 changes: 9 additions & 9 deletions gui/debugger.cpp
Expand Up @@ -29,7 +29,7 @@
#include "engines/engine.h"

#include "gui/debugger.h"
#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
#include "gui/console.h"
#elif defined(USE_READLINE)
#include <readline/readline.h>
Expand All @@ -44,7 +44,7 @@ Debugger::Debugger() {
_isActive = false;
_errStr = NULL;
_firstTime = true;
#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
_debuggerDialog = new GUI::ConsoleDialog(1.0f, 0.67f);
_debuggerDialog->setInputCallback(debuggerInputCallback, this);
_debuggerDialog->setCompletionCallback(debuggerCompletionCallback, this);
Expand All @@ -66,7 +66,7 @@ Debugger::Debugger() {
}

Debugger::~Debugger() {
#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
delete _debuggerDialog;
#endif
}
Expand All @@ -78,7 +78,7 @@ int Debugger::DebugPrintf(const char *format, ...) {

va_start(argptr, format);
int count;
#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
count = _debuggerDialog->vprintFormat(1, format, argptr);
#else
count = ::vprintf(format, argptr);
Expand Down Expand Up @@ -125,7 +125,7 @@ void Debugger::onFrame() {
}
}

#if defined(USE_TEXT_CONSOLE) && defined(USE_READLINE)
#if defined(USE_TEXT_CONSOLE_FOR_DEBUGGER) && defined(USE_READLINE)
namespace {
Debugger *g_readline_debugger;

Expand All @@ -140,7 +140,7 @@ void Debugger::enter() {
// TODO: Having three I/O methods #ifdef-ed in this file is not the
// cleanest approach to this...

#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
if (_firstTime) {
DebugPrintf("Debugger started, type 'exit' to return to the game.\n");
DebugPrintf("Type 'help' to see a little list of commands and variables.\n");
Expand Down Expand Up @@ -363,7 +363,7 @@ bool Debugger::tabComplete(const char *input, Common::String &completion) const
return true;
}

#if defined(USE_TEXT_CONSOLE) && defined(USE_READLINE)
#if defined(USE_TEXT_CONSOLE_FOR_DEBUGGER) && defined(USE_READLINE)
char *Debugger::readlineComplete(const char *input, int state) {
static CommandsMap::const_iterator iter;

Expand Down Expand Up @@ -417,7 +417,7 @@ bool Debugger::Cmd_Exit(int argc, const char **argv) {
// Print a list of all registered commands (and variables, if any),
// nicely word-wrapped.
bool Debugger::Cmd_Help(int argc, const char **argv) {
#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
const int charsPerLine = _debuggerDialog->getCharsPerLine();
#elif defined(USE_READLINE)
int charsPerLine, rows;
Expand Down Expand Up @@ -520,7 +520,7 @@ bool Debugger::Cmd_DebugFlagDisable(int argc, const char **argv) {
}

// Console handler
#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
bool Debugger::debuggerInputCallback(GUI::ConsoleDialog *console, const char *input, void *refCon) {
Debugger *debugger = (Debugger *)refCon;

Expand Down
6 changes: 3 additions & 3 deletions gui/debugger.h
Expand Up @@ -29,7 +29,7 @@

namespace GUI {

#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
class ConsoleDialog;
#endif

Expand Down Expand Up @@ -144,7 +144,7 @@ class Debugger {
*/
bool _firstTime;

#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
GUI::ConsoleDialog *_debuggerDialog;
#endif

Expand Down Expand Up @@ -194,7 +194,7 @@ class Debugger {
bool Cmd_DebugFlagEnable(int argc, const char **argv);
bool Cmd_DebugFlagDisable(int argc, const char **argv);

#ifndef USE_TEXT_CONSOLE
#ifndef USE_TEXT_CONSOLE_FOR_DEBUGGER
private:
static bool debuggerInputCallback(GUI::ConsoleDialog *console, const char *input, void *refCon);
static bool debuggerCompletionCallback(GUI::ConsoleDialog *console, const char *input, Common::String &completion, void *refCon);
Expand Down

0 comments on commit 4b7f6df

Please sign in to comment.