Skip to content

Commit

Permalink
MOHAWK: Expand Myst ME (Polish) Map Color Fix To All Stack Maps
Browse files Browse the repository at this point in the history
  • Loading branch information
@digitall
digitall committed Apr 7, 2024
1 parent dec0ec6 commit 541badb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion engines/mohawk/myst_graphics.cpp
View file
Expand Up @@ -22,6 +22,7 @@
#include "mohawk/myst.h"
#include "mohawk/myst_graphics.h"
#include "mohawk/resource.h"
#include "mohawk/myst_scripts.h"

#include "common/substream.h"
#include "common/system.h"
Expand Down Expand Up @@ -225,7 +226,8 @@ void MystGraphics::applyImagePatches(uint16 id, const MohawkSurface *mhkSurface)
}

// Fix map picture with inverted colors in Myst ME Polish version
if (id == 9934 && _vm->isGameVariant(GF_ME) && _vm->getLanguage() == Common::PL_POL) {
if (id == _vm->_stack->getMap() && _vm->isGameVariant(GF_ME) && _vm->getLanguage() == Common::PL_POL) {
debug(3, "Fix for Inverted Map Colors in Myst ME Polish Version Triggered!");
mhkSurface->getSurface()->convertToInPlace(Graphics::PixelFormat(4, 8, 8, 8, 8, 8, 16, 0, 24));
}
}
Expand Down

2 comments on commit 541badb

@ccawley2011
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workaround looks like it might be making assumptions about the current screen format. Does it work as expected with the SurfaceSDL graphics manager, or with OpenGL on big endian?

@digitall
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccawley2011 : Have updated the bug at https://bugs.scummvm.org/ticket/12044 ... on Linux x86_64 with SDL Surface output, the colors are off, but they are fine if I switch to OpenGL output.

Please sign in to comment.