Skip to content

Commit

Permalink
TSAGE: Fix compilation on NDS.
Browse files Browse the repository at this point in the history
It is not safe to assume one can construct a va_list by using NULL. Instead I
created a temporary (uninitialized!) dummy, which is passed in the call to the
Action::attached implementation. I added a TODO to resolve this temporary hack.
  • Loading branch information
Johannes Schickel committed Apr 13, 2011
1 parent fc59a52 commit 5c87136
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion engines/tsage/converse.cpp
Expand Up @@ -320,7 +320,12 @@ void SequenceManager::attached(EventHandler *newOwner, EventHandler *fmt, va_lis
}

setup();
Action::attached(newOwner, fmt, NULL);
// TODO: This is not particulary nice, since dummy is uninitialized.
// Since the default Action implementation does not access the va_list
// parameter it should be fine though. Still it would be nice to find
// a better solution to this.
va_list dummy;
Action::attached(newOwner, fmt, dummy);
}

/**
Expand Down

0 comments on commit 5c87136

Please sign in to comment.