Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SAGA: Fixed bug #3276033: IHNM: Savegame reminder not reset
- Loading branch information
Showing
3 changed files
with
11 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing that saveReminderCallback calls Interface::updateSaveReminder which in turn calls Interface::drawStatusBar, which seems to handle some graphics internal stuff, it looks odd that all this isn't protected by a Mutex. At least it seems that drawStatusBar can be called from the main thread too (like from Events::handleOneShot).
Maybe it's perfectly safe to ignore the fact that a timer proc might be a different thread, but it looks odd and should at least have a comment why this works fine.