Skip to content

Commit

Permalink
SCI: Add note about LSL1vga DoSoundSendMidi
Browse files Browse the repository at this point in the history
  • Loading branch information
wjp committed Jun 18, 2013
1 parent 7cc19bf commit 6e3510a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions engines/sci/sound/soundcmd.cpp
Expand Up @@ -534,8 +534,11 @@ reg_t SoundCommandParser::kDoSoundSendMidi(int argc, reg_t *argv, reg_t acc) {
byte channel = argv[1].toUint16() & 0xf;
byte midiCmd = argv[2].toUint16() & 0xff;

// TODO: first there is a 4-parameter variant of this call which needs to get reversed
// second the current code isn't 100% accurate, sierra sci does checks on the 4th parameter
// TODO: There is a 4 parameter variant of this call,
// used by at least lsl1vga.
// It lacks a midiCmd argument, but for this variant midiCmd defaults to
// 0xB0 (controller). If argv[2] is 0xFF, midiCmd is 0xE0
// (pitchwheel). The exact parameters need to be investigated further.
if (argc == 4)
return acc;

Expand Down

0 comments on commit 6e3510a

Please sign in to comment.