Skip to content

Commit

Permalink
SAMSUNGTV: update port
Browse files Browse the repository at this point in the history
  • Loading branch information
aquadran committed May 23, 2011
1 parent 76b8afc commit 944e0be
Show file tree
Hide file tree
Showing 10 changed files with 127 additions and 35 deletions.
4 changes: 0 additions & 4 deletions backends/base-backend.cpp
Expand Up @@ -58,12 +58,8 @@ void BaseBackend::fillScreen(uint32 col) {


#if defined(UNIX)
#if defined(SAMSUNGTV)
#define DEFAULT_CONFIG_FILE "/dtv/usb/sda1/.scummvmrc"
#else
#define DEFAULT_CONFIG_FILE ".scummvmrc"
#endif
#endif

#if !defined(UNIX)
#define DEFAULT_CONFIG_FILE "scummvm.ini"
Expand Down
58 changes: 58 additions & 0 deletions backends/graphics/samsungtvsdl/samsungtvsdl-graphics.cpp
@@ -0,0 +1,58 @@
/* ScummVM - Graphic Adventure Engine
*
* ScummVM is the legal property of its developers, whose names
* are too numerous to list here. Please refer to the COPYRIGHT
* file distributed with this source distribution.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
*/

#include "backends/platform/samsungtv/samsungtv.h"
#include "backends/events/samsungtvsdl/samsungtvsdl-events.h"
#include "backends/graphics/samsungtvsdl/samsungtvsdl-graphics.h"

#if defined(SAMSUNGTV)

SamsungTVSdlGraphicsManager::SamsungTVSdlGraphicsManager(SdlEventSource *sdlEventSource)
: SdlGraphicsManager(sdlEventSource) {
}

bool SamsungTVSdlGraphicsManager::hasFeature(OSystem::Feature f) {
return
(f == OSystem::kFeatureAspectRatioCorrection) ||
(f == OSystem::kFeatureCursorHasPalette);
}

void SamsungTVSdlGraphicsManager::setFeatureState(OSystem::Feature f, bool enable) {
switch (f) {
case OSystem::kFeatureAspectRatioCorrection:
SdlGraphicsManager::setFeatureState(f, enable);
break;
default:
break;
}
}

bool SamsungTVSdlGraphicsManager::getFeatureState(OSystem::Feature f) {
switch (f) {
case OSystem::kFeatureAspectRatioCorrection:
return SdlGraphicsManager::getFeatureState(f);
default:
return false;
}
}

#endif
41 changes: 41 additions & 0 deletions backends/graphics/samsungtvsdl/samsungtvsdl-graphics.h
@@ -0,0 +1,41 @@
/* ScummVM - Graphic Adventure Engine
*
* ScummVM is the legal property of its developers, whose names
* are too numerous to list here. Please refer to the COPYRIGHT
* file distributed with this source distribution.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
*/

#ifndef BACKENDS_GRAPHICS_SAMSUNGTV_H
#define BACKENDS_GRAPHICS_SAMSUNGTV_H

#if defined(SAMSUNGTV)

#include "backends/graphics/sdl/sdl-graphics.h"

class SamsungTVSdlGraphicsManager : public SdlGraphicsManager {
public:
SamsungTVSdlGraphicsManager(SdlEventSource *sdlEventSource);

bool hasFeature(OSystem::Feature f);
void setFeatureState(OSystem::Feature f, bool enable);
bool getFeatureState(OSystem::Feature f);
};

#endif

#endif
3 changes: 2 additions & 1 deletion backends/module.mk
Expand Up @@ -149,7 +149,8 @@ endif

ifeq ($(BACKEND),samsungstv)
MODULE_OBJS += \
events/samsungtvsdl/samsungtvsdl-events.o
events/samsungtvsdl/samsungtvsdl-events.o \
graphics/samsungtvsdl/samsungtvsdl-graphics.o
endif

ifeq ($(BACKEND),webos)
Expand Down
4 changes: 2 additions & 2 deletions backends/platform/samsungtv/main.cpp
Expand Up @@ -38,7 +38,7 @@ extern "C" int Game_Main(char *path, char *) {
assert(g_system);

// Pre initialize the backend
((OSystem_SDL_SamsungTV *)g_system)->init();
((OSystem_POSIX *)g_system)->init();

#ifdef DYNAMIC_MODULES
PluginManager::instance().addPluginProvider(new SDLPluginProvider());
Expand All @@ -48,7 +48,7 @@ extern "C" int Game_Main(char *path, char *) {
int res = scummvm_main(0, 0);

// Free OSystem
delete g_system;
delete (OSystem_SDL_SamsungTV *)g_system;

return res;
}
Expand Down
36 changes: 13 additions & 23 deletions backends/platform/samsungtv/samsungtv.cpp
Expand Up @@ -22,46 +22,36 @@

#include "backends/platform/samsungtv/samsungtv.h"
#include "backends/events/samsungtvsdl/samsungtvsdl-events.h"
#include "backends/graphics/samsungtvsdl/samsungtvsdl-graphics.h"

#if defined(SAMSUNGTV)

OSystem_SDL_SamsungTV::OSystem_SDL_SamsungTV()
:
OSystem_POSIX("/dtv/usb/sda1/.scummvmrc") {
}

bool OSystem_SDL_SamsungTV::hasFeature(Feature f) {
return
(f == OSystem::kFeatureAspectRatioCorrection) ||
(f == OSystem::kFeatureCursorHasPalette);
OSystem_POSIX("/mtd_rwarea/scummvm/.scummvmrc") {
}

void OSystem_SDL_SamsungTV::initBackend() {
// Create the events manager
if (_eventSource == 0)
_eventSource = new SamsungTVSdlEventSource();

if (_graphicsManager == 0)
_graphicsManager = new SamsungTVSdlGraphicsManager(_eventSource);

// Call parent implementation of this method
OSystem_SDL::initBackend();
OSystem_POSIX::initBackend();
}

void OSystem_SDL_SamsungTV::setFeatureState(Feature f, bool enable) {
switch (f) {
case OSystem::kFeatureAspectRatioCorrection:
_graphicsManager->setFeatureState(f, enable);
break;
default:
break;
}
void OSystem_SDL_SamsungTV::quit() {
delete this;
}

bool OSystem_SDL_SamsungTV::getFeatureState(Feature f) {
switch (f) {
case OSystem::kFeatureAspectRatioCorrection:
return _graphicsManager->getFeatureState(f);
default:
return false;
}
void OSystem_SDL_SamsungTV::fatalError() {
delete this;
// FIXME
warning("fatal error");
for (;;) {}
}

#endif
10 changes: 6 additions & 4 deletions backends/platform/samsungtv/samsungtv.h
Expand Up @@ -23,17 +23,19 @@
#ifndef PLATFORM_SDL_SAMSUNGTV_H
#define PLATFORM_SDL_SAMSUNGTV_H

#if defined(SAMSUNGTV)

#include "backends/platform/sdl/posix/posix.h"

class OSystem_SDL_SamsungTV : public OSystem_POSIX {
public:
OSystem_SDL_SamsungTV();

virtual void initBackend();

virtual bool hasFeature(Feature f);
virtual void setFeatureState(Feature f, bool enable);
virtual bool getFeatureState(Feature f);
virtual void quit();
virtual void fatalError();
};

#endif

#endif
1 change: 1 addition & 0 deletions backends/platform/sdl/main.cpp
Expand Up @@ -33,6 +33,7 @@
!defined(DINGUX) && \
!defined(CAANOO) && \
!defined(LINUXMOTO) && \
!defined(SAMSUNGTV) && \
!defined(OPENPANDORA)

#include "backends/platform/sdl/sdl.h"
Expand Down
3 changes: 3 additions & 0 deletions backends/platform/sdl/posix/posix.cpp
Expand Up @@ -82,6 +82,9 @@ Common::WriteStream *OSystem_POSIX::createLogFile() {
#else
logFile += "/.scummvm";
#endif
#ifdef SAMSUNGTV
logFile = "/mtd_ram";
#endif

struct stat sb;

Expand Down
2 changes: 1 addition & 1 deletion backends/saves/posix/posix-saves.cpp
Expand Up @@ -50,7 +50,7 @@
POSIXSaveFileManager::POSIXSaveFileManager() {
// Register default savepath based on HOME
#if defined(SAMSUNGTV)
ConfMan.registerDefault("savepath", "/dtv/usb/sda1/.scummvm");
ConfMan.registerDefault("savepath", "/mtd_rwarea/scummvm/savegames");
#else
Common::String savePath;
const char *home = getenv("HOME");
Expand Down

9 comments on commit 944e0be

@fingolfin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that you are working on the port :). Will you also backport / cherrypick this to the 1.3 branch?

@aquadran
Copy link
Member Author

@aquadran aquadran commented on 944e0be May 23, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aquadran
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems issue no longer valid, I'm confused :/ It works on olders revisions. However it does not startup at all (no crash) with revisions from beggining May. (it's specific bechaviour on this platform if something is not right). I know it works with 2 May , and doesn't with 5 May. However I noticed small refactor in backend in between, maybe something is not compiled properly for samsung case. I'll try fix that when I back home today.

@aquadran
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I found typo at refactor module.mk, so I guess is that, I'll test later.

@aquadran
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some tries I gave up today with git. I ask wjp for apply patch, but I don't know if he get time before tagging. So if you can do that please apply to branch this patch: http://www.smallfiles.org/download/47/samsungtv.diff.html

@wjp
Copy link
Contributor

@wjp wjp commented on 944e0be May 24, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed it as 48b4c6c to branch-1-3-0

@aquadran
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@aquadran
Copy link
Member Author

@aquadran aquadran commented on 944e0be Jun 6, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fingolfin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.