Skip to content

Commit

Permalink
SCI32: Fix PQ4 Barbie shoe points patch selector
Browse files Browse the repository at this point in the history
The original script patch had the correct literal value but the
wrong selector name in the comment for the literal value, so when
it was converted to use a selector lookup in
c5dce17, the patch broke because
the wrong selector name was used.

Fixes Trac#10392. Closes gh-1107.
  • Loading branch information
dafioram authored and csnover committed Jan 17, 2018
1 parent e96d32e commit 9518fd7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions engines/sci/engine/script_patches.cpp
Expand Up @@ -141,7 +141,7 @@ static const char *const selectorNameTable[] = {
"setScale", // LSL6hires
"setScaler", // LSL6hires
"readWord", // LSL7, Phant1, Torin
"flag", // PQ4
"points", // PQ4
"select", // PQ4
"handle", // RAMA
"saveFilePtr", // RAMA
Expand Down Expand Up @@ -214,7 +214,7 @@ enum ScriptPatcherSelectors {
SELECTOR_setScale,
SELECTOR_setScaler,
SELECTOR_readWord,
SELECTOR_flag,
SELECTOR_points,
SELECTOR_select,
SELECTOR_handle,
SELECTOR_saveFilePtr,
Expand Down Expand Up @@ -4644,15 +4644,15 @@ static const uint16 pq4CdSpeechAndSubtitlesPatch[] = {
// bar earlier in the game, and checks local 3 then, so just check local 3 in
// both cases to prevent the game from appearing to be in an unwinnable state
// just because the player interacted in the "wrong" order.
// Applies to at least: English floppy, German floppy, English CD
// Applies to at least: English floppy, German floppy, English CD, German CD
static const uint16 pq4BittyKittyShowBarieRedShoeSignature[] = {
// stripper::noun check is for checking, if police badge was shown
SIG_MAGICDWORD,
0x89, 0x9a, // lsg global[$9a]
0x35, 0x02, // ldi 2
0x1e, // gt?
0x30, SIG_UINT16(0x0028), // bnt [skip 2 points code]
0x39, SIG_SELECTOR8(flag), // pushi $61 (flag)
0x39, SIG_SELECTOR8(points), // pushi $61 (points)
SIG_END
};

Expand Down

0 comments on commit 9518fd7

Please sign in to comment.