HOPKINS: Get rid of a magic value in save/load dialogs

scummvm · Feb 26, 2013 · c74361b · c74361b
1 parent 88c216e
commit c74361b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/engines/hopkins/dialogs.cpp b/engines/hopkins/dialogs.cpp
@@ -568,7 +568,7 @@ void DialogsManager::testDialogOpening() {
  */
 void DialogsManager::showLoadGame() {
 	_vm->_eventsManager.VBL();
-	showSaveLoad(2);
+	showSaveLoad(MODE_LOAD);
 
 	int slotNumber;
 	do {
@@ -597,7 +597,7 @@ void DialogsManager::showLoadGame() {
 void DialogsManager::showSaveGame() {
 	_vm->_eventsManager.VBL();
 
-	showSaveLoad(1);
+	showSaveLoad(MODE_SAVE);
 	int slotNumber;
 	do {
 		slotNumber = searchSavegames();
@@ -625,7 +625,7 @@ void DialogsManager::showSaveGame() {
 /**
  * Load/Save dialog
  */
-void DialogsManager::showSaveLoad(int a1) {
+void DialogsManager::showSaveLoad(SaveLoadMode mode) {
 	Common::String filename;
 
 	if (_vm->getPlatform() == Common::kPlatformOS2 || _vm->getPlatform() == Common::kPlatformBeOS)
@@ -649,14 +649,14 @@ void DialogsManager::showSaveLoad(int a1) {
 	_vm->_graphicsManager.Sprite_Vesa(_vm->_graphicsManager._vesaBuffer, _vm->_objectsManager._saveLoadSprite, _vm->_eventsManager._startPos.x + 483, 360, 0);
 
 	if (_vm->_globals._language == LANG_FR) {
-		if (a1 == 1)
+		if (mode == MODE_SAVE)
 			_vm->_graphicsManager.Sprite_Vesa(_vm->_graphicsManager._vesaBuffer, _vm->_objectsManager._saveLoadSprite, _vm->_eventsManager._startPos.x + 525, 375, 1);
-		else if (a1 == 2)
+		else if (mode == MODE_LOAD)
 			_vm->_graphicsManager.Sprite_Vesa(_vm->_graphicsManager._vesaBuffer, _vm->_objectsManager._saveLoadSprite, _vm->_eventsManager._startPos.x + 515, 375, 2);
 	} else {
-		if (a1 == 1)
+		if (mode == MODE_SAVE)
 			_vm->_graphicsManager.Sprite_Vesa(_vm->_graphicsManager._vesaBuffer, _vm->_objectsManager._saveLoadSprite, _vm->_eventsManager._startPos.x + 535, 372, 1);
-		else if (a1 == 2)
+		else if (mode == MODE_LOAD)
 			_vm->_graphicsManager.Sprite_Vesa(_vm->_graphicsManager._vesaBuffer, _vm->_objectsManager._saveLoadSprite, _vm->_eventsManager._startPos.x + 539, 372, 2);
 	}
 

diff --git a/engines/hopkins/dialogs.h b/engines/hopkins/dialogs.h
@@ -31,14 +31,16 @@ namespace Hopkins {
 
 class HopkinsEngine;
 
+enum SaveLoadMode { MODE_SAVE = 1, MODE_LOAD = 2 };
+
 /**
  * Class for manging game dialogs
  */
 class DialogsManager {
 private:
 	HopkinsEngine *_vm;
 
-	void showSaveLoad(int a1);
+	void showSaveLoad(SaveLoadMode mode);
 	int  searchSavegames();
 public:
 	byte *_inventWin1;