Skip to content

Commit

Permalink
DEVTOOLS: Make Coverity happy.
Browse files Browse the repository at this point in the history
This is mainly due to unhandled clang __has_featrure() buit-in.
I do not like this hack, but Coverity proved to be a very good tool for us.
  • Loading branch information
sev- committed Sep 27, 2013
1 parent 8053989 commit ca5804a
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 6 deletions.
4 changes: 4 additions & 0 deletions devtools/convbdf.cpp
Expand Up @@ -20,6 +20,10 @@
*
*/

#ifndef __has_feature // Optional of course.
#define __has_feature(x) 0 // Compatibility with non-clang compilers.
#endif

#include <fstream>
#include <string>
#include <stdio.h>
Expand Down
4 changes: 0 additions & 4 deletions devtools/create_mortdat/create_mortdat.cpp
Expand Up @@ -33,10 +33,6 @@
#undef main
#endif // main

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#include "common/endian.h"
#include "create_mortdat.h"
#include "enginetext.h"
Expand Down
2 changes: 1 addition & 1 deletion devtools/create_neverhood/create_neverhood.cpp
Expand Up @@ -30,8 +30,8 @@
#undef main
#endif // main

#include <vector>
#include "create_neverhood.h"
#include <vector>
#include "md5.h"
#include "tables.h"

Expand Down
4 changes: 4 additions & 0 deletions devtools/create_project/create_project.h
Expand Up @@ -23,6 +23,10 @@
#ifndef TOOLS_CREATE_PROJECT_H
#define TOOLS_CREATE_PROJECT_H

#ifndef __has_feature // Optional of course.
#define __has_feature(x) 0 // Compatibility with non-clang compilers.
#endif

#include <map>
#include <list>
#include <string>
Expand Down
3 changes: 2 additions & 1 deletion devtools/create_translations/create_translations.cpp
Expand Up @@ -22,6 +22,8 @@
* The generated files is used by ScummVM to propose translation of its GUI.
*/

#include "create_translations.h"

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
Expand All @@ -34,7 +36,6 @@
#undef main
#endif // main

#include "create_translations.h"
#include "po_parser.h"
#include "cp_parser.h"

Expand Down
4 changes: 4 additions & 0 deletions devtools/create_translations/create_translations.h
Expand Up @@ -28,4 +28,8 @@ typedef unsigned short uint16;
typedef unsigned int uint32;
typedef signed short int16;

#ifndef __has_feature // Optional of course.
#define __has_feature(x) 0 // Compatibility with non-clang compilers.
#endif

#endif /* CREATE_TRANSLATIONS_H */

0 comments on commit ca5804a

Please sign in to comment.