TITANIC: Reduce header includes for star_control files

Minimized a lot of the unncessary files includes in the implementation files as well.
scummvm · Aug 24, 2017 · d01354a · d01354a
1 parent 9b10f5d
commit d01354a
Show file tree

Hide file tree

Showing 39 changed files with 90 additions and 58 deletions.
diff --git a/engines/titanic/star_control/base_stars.cpp b/engines/titanic/star_control/base_stars.cpp
@@ -22,6 +22,7 @@
 
 #include "titanic/star_control/base_stars.h"
 #include "titanic/star_control/star_camera.h"
+#include "titanic/star_control/star_closeup.h"
 #include "titanic/star_control/star_ref.h"
 #include "titanic/support/files_manager.h"
 #include "titanic/support/simple_file.h"

diff --git a/engines/titanic/star_control/base_stars.h b/engines/titanic/star_control/base_stars.h
@@ -23,15 +23,21 @@
 #ifndef TITANIC_BASE_STARS_H
 #define TITANIC_BASE_STARS_H
 
-#include "titanic/star_control/frange.h"
-#include "titanic/star_control/star_closeup.h"
-#include "titanic/star_control/surface_area.h"
+#include "titanic/star_control/frange.h" // class Fvector
+#include "common/array.h"
+
+namespace Common {
+class SeekableReadStream;
+}
 
 namespace Titanic {
 
 enum StarMode { MODE_STARFIELD = 0, MODE_PHOTO = 1 };
 
 class CStarCamera;
+class CStarCloseup;
+class CString;
+class CSurfaceArea;
 class SimpleFile;
 
 struct CBaseStarEntry {

diff --git a/engines/titanic/star_control/camera_auto_mover.cpp b/engines/titanic/star_control/camera_auto_mover.cpp
@@ -22,9 +22,6 @@
 
 #include "titanic/star_control/camera_auto_mover.h"
 #include "titanic/star_control/fmatrix.h"
-#include "titanic/star_control/error_code.h"
-#include "common/textconsole.h"
-
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/camera_mover.cpp b/engines/titanic/star_control/camera_mover.cpp
@@ -21,7 +21,11 @@
  */
 
 #include "titanic/star_control/camera_mover.h"
-#include "common/textconsole.h"
+#include "titanic/star_control/base_stars.h" // includes class CStarVector
+#include "titanic/star_control/error_code.h"
+#include "titanic/star_control/fmatrix.h" // Also has class FVector
+#include "titanic/support/simple_file.h"
+// Not currently being used: #include "common/textconsole.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/camera_mover.h b/engines/titanic/star_control/camera_mover.h
@@ -23,13 +23,18 @@
 #ifndef TITANIC_CAMERA_MOVER_H
 #define TITANIC_CAMERA_MOVER_H
 
-#include "titanic/support/simple_file.h"
-#include "titanic/star_control/base_stars.h"
-#include "titanic/star_control/error_code.h"
-#include "titanic/star_control/fmatrix.h"
+//#include "titanic/support/simple_file.h"
+//#include "titanic/star_control/error_code.h"
+//#include "titanic/star_control/fmatrix.h" // class FVector
 
 namespace Titanic {
 
+class CErrorCode;
+class CStarVector;
+class FMatrix;
+class FVector;
+class SimpleFile;
+
 struct CNavigationInfo {
 	double _speed;
 	double _speedChangeCtr;

diff --git a/engines/titanic/star_control/daffine.cpp b/engines/titanic/star_control/daffine.cpp
@@ -21,7 +21,7 @@
  */
 
 #include "titanic/star_control/daffine.h"
-#include "titanic/star_control/fmatrix.h"
+#include "titanic/star_control/fmatrix.h" // includes FVector
 #include "titanic/star_control/matrix_transform.h"
 
 namespace Titanic {

diff --git a/engines/titanic/star_control/daffine.h b/engines/titanic/star_control/daffine.h
@@ -24,7 +24,7 @@
 #define TITANIC_DAFFINE_H
 
 #include "titanic/star_control/dvector.h"
-#include "titanic/star_control/fvector.h"
+#include "titanic/star_control/fvector.h" // definition of Axis enum
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/dvector.cpp b/engines/titanic/star_control/dvector.cpp
@@ -22,7 +22,6 @@
 
 #include "titanic/star_control/dvector.h"
 #include "titanic/star_control/daffine.h"
-#include "common/algorithm.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/fpoint.cpp b/engines/titanic/star_control/fpoint.cpp
@@ -21,7 +21,6 @@
  */
 
 #include "titanic/star_control/fpoint.h"
-#include "common/algorithm.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/frange.cpp b/engines/titanic/star_control/frange.cpp
@@ -20,8 +20,8 @@
  *
  */
 
-#include "common/algorithm.h"
 #include "titanic/star_control/frange.h"
+#include "common/algorithm.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/fvector.cpp b/engines/titanic/star_control/fvector.cpp
@@ -23,8 +23,8 @@
 #include "titanic/star_control/fvector.h"
 #include "titanic/star_control/dvector.h"
 #include "titanic/star_control/fpose.h"
-#include "common/algorithm.h"
-#include "common/textconsole.h"
+//#include "common/algorithm.h"
+//#include "common/textconsole.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/marked_auto_mover.cpp b/engines/titanic/star_control/marked_auto_mover.cpp
@@ -22,8 +22,7 @@
 
 #include "titanic/star_control/marked_auto_mover.h"
 #include "titanic/star_control/error_code.h"
-#include "common/array.h"
-#include "common/textconsole.h"
+// Not currently being used: #include "common/textconsole.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/marked_camera_mover.cpp b/engines/titanic/star_control/marked_camera_mover.cpp
@@ -21,8 +21,9 @@
  */
 
 #include "titanic/star_control/marked_camera_mover.h"
-#include "common/array.h"
-#include "common/textconsole.h"
+#include "titanic/star_control/base_stars.h" // includes class CStarVector
+#include "titanic/star_control/error_code.h"
+// Not currently being used: #include "common/textconsole.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/matrix_transform.cpp b/engines/titanic/star_control/matrix_transform.cpp
@@ -21,6 +21,7 @@
  */
 
 #include "titanic/star_control/matrix_transform.h"
+#include "titanic/star_control/daffine.h"
 #include "common/textconsole.h"
 
 namespace Titanic {

diff --git a/engines/titanic/star_control/matrix_transform.h b/engines/titanic/star_control/matrix_transform.h
@@ -23,10 +23,12 @@
 #ifndef TITANIC_MATRIX_TRANSFORM_H
 #define TITANIC_MATRIX_TRANSFORM_H
 
-#include "titanic/star_control/daffine.h"
+#include "titanic/star_control/dvector.h"
 
 namespace Titanic {
 
+class Daffine;
+
 class CMatrixTransform {
 private:
 	double fn2(const CMatrixTransform &src);

diff --git a/engines/titanic/star_control/star_closeup.cpp b/engines/titanic/star_control/star_closeup.cpp
@@ -21,7 +21,9 @@
  */
 
 #include "titanic/star_control/star_closeup.h"
+#include "titanic/star_control/error_code.h"
 #include "titanic/star_control/star_camera.h"
+#include "titanic/star_control/surface_area.h"
 #include "titanic/titanic.h"
 
 namespace Titanic {

diff --git a/engines/titanic/star_control/star_closeup.h b/engines/titanic/star_control/star_closeup.h
@@ -23,15 +23,16 @@
 #ifndef TITANIC_STAR_CLOSEUP_H
 #define TITANIC_STAR_CLOSEUP_H
 
-#include "common/array.h"
 #include "titanic/star_control/fvector.h"
 #include "titanic/star_control/fpose.h"
-#include "titanic/star_control/error_code.h"
 #include "titanic/star_control/surface_area.h"
+#include "common/array.h"
 
 namespace Titanic {
 
+class CErrorCode;
 class CStarCamera;
+class CSurfaceArea;
 
 /**
  * Handles drawing a 3D rendered closeup of a star

diff --git a/engines/titanic/star_control/star_control.cpp b/engines/titanic/star_control/star_control.cpp
@@ -21,17 +21,13 @@
  */
 
 #include "titanic/star_control/star_control.h"
-#include "titanic/star_control/daffine.h"
-#include "titanic/star_control/fpose.h"
-#include "titanic/star_control/camera_mover.h"
-#include "titanic/star_control/star_camera.h"
-#include "titanic/star_control/error_code.h"
 #include "titanic/core/dont_save_file_item.h"
 #include "titanic/core/project_item.h"
-#include "titanic/core/view_item.h"
+#include "titanic/game_manager.h"
 #include "titanic/pet_control/pet_control.h"
+#include "titanic/star_control/camera_mover.h"
+#include "titanic/star_control/error_code.h" // CErrorCode
 #include "titanic/support/screen_manager.h"
-#include "titanic/game_manager.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/star_control.h b/engines/titanic/star_control/star_control.h
@@ -23,13 +23,14 @@
 #ifndef TITANIC_STAR_CONTROL_H
 #define TITANIC_STAR_CONTROL_H
 
-#include "titanic/core/game_object.h"
+#include "titanic/core/game_object.h" // class SimpleFile
 #include "titanic/star_control/star_field.h"
 #include "titanic/star_control/star_view.h"
-#include "titanic/pet_control/pet_control.h"
 
 namespace Titanic {
 
+class CPetControl;
+
 class CStarControl : public CGameObject {
 	DECLARE_MESSAGE_MAP;
 	bool MouseButtonDownMsg(CMouseButtonDownMsg *msg);

diff --git a/engines/titanic/star_control/star_crosshairs.cpp b/engines/titanic/star_control/star_crosshairs.cpp
@@ -25,6 +25,7 @@
 #include "titanic/star_control/star_camera.h"
 #include "titanic/star_control/star_field.h"
 #include "titanic/star_control/star_ref.h"
+#include "titanic/support/simple_file.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/star_crosshairs.h b/engines/titanic/star_control/star_crosshairs.h
@@ -23,19 +23,19 @@
 #ifndef TITANIC_STAR_CROSSHAIRS_H
 #define TITANIC_STAR_CROSSHAIRS_H
 
-#include "common/array.h"
-#include "common/rect.h"
 #include "titanic/star_control/base_stars.h"
-#include "titanic/star_control/surface_area.h"
 #include "titanic/star_control/fpoint.h"
-#include "titanic/support/simple_file.h"
+#include "titanic/star_control/surface_area.h"
 #include "titanic/support/video_surface.h"
+#include "common/array.h"
+#include "common/rect.h"
 
 namespace Titanic {
 
 class CStarField;
 class CStarMarkers;
 class CStarCamera;
+class SimpleFile;
 
 class CStarCrosshairs {
 private:

diff --git a/engines/titanic/star_control/star_field_base.cpp b/engines/titanic/star_control/star_field_base.cpp
@@ -23,6 +23,7 @@
 #include "titanic/star_control/star_field_base.h"
 #include "titanic/debugger.h"
 #include "titanic/star_control/star_camera.h"
+#include "titanic/support/simple_file.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/star_markers.cpp b/engines/titanic/star_control/star_markers.cpp
@@ -22,6 +22,7 @@
 
 #include "titanic/star_control/star_markers.h"
 #include "titanic/star_control/star_camera.h"
+#include "titanic/star_control/surface_area.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/star_markers.h b/engines/titanic/star_control/star_markers.h
@@ -24,6 +24,7 @@
 #define TITANIC_STAR_MARKERS_H
 
 #include "titanic/star_control/base_stars.h"
+
 namespace Titanic {
 
 class CStarMarkers : public CBaseStars {

diff --git a/engines/titanic/star_control/star_points1.cpp b/engines/titanic/star_control/star_points1.cpp
@@ -22,6 +22,7 @@
 
 #include "titanic/star_control/star_points1.h"
 #include "titanic/star_control/star_camera.h"
+#include "titanic/star_control/surface_area.h"
 #include "titanic/support/files_manager.h"
 #include "titanic/titanic.h"
 

diff --git a/engines/titanic/star_control/star_points1.h b/engines/titanic/star_control/star_points1.h
@@ -23,13 +23,13 @@
 #ifndef TITANIC_STAR_POINTS1_H
 #define TITANIC_STAR_POINTS1_H
 
-#include "common/array.h"
-#include "titanic/star_control/surface_area.h"
 #include "titanic/star_control/fvector.h"
+#include "common/array.h"
 
 namespace Titanic {
 
 class CStarCamera;
+class CSurfaceArea;
 
 class CStarPoints1 {
 	struct CStarPointEntry : public FVector {

diff --git a/engines/titanic/star_control/star_points2.cpp b/engines/titanic/star_control/star_points2.cpp
@@ -22,6 +22,7 @@
 
 #include "titanic/star_control/star_points2.h"
 #include "titanic/star_control/star_camera.h"
+#include "titanic/star_control/surface_area.h"
 #include "titanic/support/files_manager.h"
 #include "titanic/titanic.h"
 

diff --git a/engines/titanic/star_control/star_points2.h b/engines/titanic/star_control/star_points2.h
@@ -23,13 +23,13 @@
 #ifndef TITANIC_STAR_POINTS2_H
 #define TITANIC_STAR_POINTS2_H
 
-#include "common/array.h"
 #include "titanic/star_control/fvector.h"
-#include "titanic/star_control/surface_area.h"
+#include "common/array.h"
 
 namespace Titanic {
 
 class CStarCamera;
+class CSurfaceArea;
 
 class CStarPoints2 {
 	struct CStarPointEntry {

diff --git a/engines/titanic/star_control/star_ref.cpp b/engines/titanic/star_control/star_ref.cpp
@@ -21,6 +21,8 @@
  */
 
 #include "titanic/star_control/star_ref.h"
+#include "titanic/star_control/star_camera.h"
+#include "titanic/star_control/surface_area.h"
 
 namespace Titanic {
 

diff --git a/engines/titanic/star_control/star_ref.h b/engines/titanic/star_control/star_ref.h
@@ -20,16 +20,17 @@
  *
  */
 
-#include "common/rect.h"
 #include "titanic/star_control/base_stars.h"
-#include "titanic/star_control/star_camera.h"
-#include "titanic/star_control/surface_area.h"
+#include "common/rect.h"
 
 #ifndef TITANIC_STAR_REF_H
 #define TITANIC_STAR_REF_H
 
 namespace Titanic {
 
+class CStarCamera;
+class CSurfaceArea;
+
 class CBaseStarRef {
 protected:
 	CBaseStars *_stars;

diff --git a/engines/titanic/star_control/star_view.cpp b/engines/titanic/star_control/star_view.cpp
@@ -22,14 +22,15 @@
 
 #include "titanic/star_control/star_view.h"
 #include "titanic/star_control/camera_mover.h"
+#include "titanic/star_control/error_code.h"
 #include "titanic/star_control/fvector.h"
 #include "titanic/star_control/star_control.h"
 #include "titanic/star_control/star_field.h"
-#include "titanic/star_control/error_code.h"
 #include "titanic/support/screen_manager.h"
 #include "titanic/support/simple_file.h"
 #include "titanic/core/game_object.h"
 #include "titanic/messages/pet_messages.h"
+#include "titanic/pet_control/pet_control.h"
 
 namespace Titanic {