Skip to content

Commit

Permalink
SCUMM: Added FIXME to our old AdLib resource conversion code.
Browse files Browse the repository at this point in the history
We handle command 0x80 incorrectly, which results in sound effects never
looping. This is the cause for bug #2027877 for example. I add this FIXME
since it is (probably) non-trivial to fix and so it won't be forgotten.
  • Loading branch information
Johannes Schickel committed Aug 3, 2011
1 parent 7e7e606 commit e1d881a
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions engines/scumm/sound.cpp
Expand Up @@ -1997,6 +1997,14 @@ static void convertADResource(ResourceManager *res, const GameSettings& game, Re
break;

case 0x80:
// FIXME: This is incorrect. The original uses 0x80 for
// looping a single channel. We currently interpret it as stop
// thus we won't get looping for sound effects. It should
// always jump to the start of the channel.
//
// Since we convert the data to MIDI and we can not ony loop a
// single channel via MIDI fixing this will require some more
// thought.
track_time[ch] = -1;
src_ptr ++;
break;
Expand Down

0 comments on commit e1d881a

Please sign in to comment.