Skip to content

Commit

Permalink
COMMON: Remove outdated fixme
Browse files Browse the repository at this point in the history
  • Loading branch information
wjp committed Nov 17, 2011
1 parent ae54885 commit f17b9bc
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions backends/timer/default/default-timer.cpp
Expand Up @@ -122,7 +122,7 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v

for (i = _callbacks.begin(); i != _callbacks.end(); ++i) {
if (i->_value == callback) {
error("Same callback is referred by different names (%s vs %s)", i->_key.c_str(), id.c_str());
error("Same callback added twice (old name: %s, new name: %s)", i->_key.c_str(), id.c_str());
}
}
_callbacks[id] = callback;
Expand All @@ -136,12 +136,6 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v
slot->nextFireTimeMicro = interval % 1000;
slot->next = 0;

// FIXME: It seems we do allow the client to add one callback multiple times over here,
// but "removeTimerProc" will remove *all* added instances. We should either prevent
// multiple additions of a timer proc OR we should change removeTimerProc to only remove
// a specific timer proc entry.
// Probably we can safely just allow a single addition of a specific function once
// and just update our Timer documentation accordingly.
insertPrioQueue(_head, slot);

return true;
Expand Down

0 comments on commit f17b9bc

Please sign in to comment.