Skip to content
Commits on Jun 26, 2016
  1. @bgK

    MOHAWK: Remap bitmaps not to use undefined colors

    The Spanish version of Myst has bitmaps that use palette indices in the system
    reserved range. Affected pixels previously used colors from the Windows system
    palette instead of the bitmap's own palette, resulting in visual glitches.
    Bitmaps are now remapped to the screen palette which is made of the Windows
    reserved palette and part of the bitmap palette. The original engine used GDI's
    StretchDIBits with DIB_RGB_COLORS to achieve the same result.
    Fixes #7153.
    bgK committed Jun 26, 2016
Commits on Jun 25, 2016
  1. @m-kiewitz

    SCI: Add getGameObjectName to fix compilation

    Is needed for 80462b3 (Fix auto-saving in the fan-made Cascade Quest)
    m-kiewitz committed Jun 25, 2016
  2. @m-kiewitz

    SCI: Fix auto-saving in the fan-made Cascade Quest

    Script patch to change the fixed slot 999 to fixed slot 99 in the
    game scripts and additional code for kSaveGame, that checks for
    Cascade Quest + slot 99 and will then use ScummVM slot 0, which
    is our auto-save slot.
    Fixes bug #7007
    Also added the game name to the other fan-made script patch.
    m-kiewitz committed Jun 25, 2016
  3. @bluegr

    SCI32: Properly initialize pausedAtTick inside Audio32::play()

    Fixes audio not playing in later SCI32 games that use Audio32
    bluegr committed Jun 25, 2016
  4. @bluegr
  5. @sev-

    TOLTECS: Fix typo

    sev- committed Jun 25, 2016
  6. @sev-
  7. @m-kiewitz

    SCI: Script patch for critical Colonel's Bequest game bug

    This patch is about an issue, when interacting with the
    armor in room 37 (main house, downstairs).
    This bug also happened, when using the original interpreter
    and effectively froze the game depending on the coordinate
    of Laura Bow, when the command was entered.
    Fixes bug #7119
    Versions affected: English PC/Atari ST/Amiga Floppy
    m-kiewitz committed Jun 25, 2016
  8. @m-kiewitz

    SCI: Fix SQ1VGA script patch, fixes bug #7145

    Script patch used "lsg" for one instruction, which should have
    been "lag" instead.
    Caused issues with the spider droid.
    Added more details about this script patch in comments.
    Also specified the method for a qfg3 script patch in comments.
    m-kiewitz committed Jun 25, 2016
Commits on Jun 23, 2016
  1. @bluegr

    SCI32: Properly initialize AudioChannel inside Audio32::play()

    Fixes audio issues caused by uninitialized variables
    bluegr committed Jun 23, 2016
  2. @bluegr

    SCI32: Fix usage of the C++11 override keyword with MSVC

    MSVC does not allow the usage of the "override" keyword on function
    definition, only on declaration
    bluegr committed Jun 23, 2016
  3. @bluegr
  4. @bluegr
Commits on Jun 22, 2016
  1. @csnover

    SCI: Assert on seeks past the end of audio resource bundles

    This should never be allowed to happen, but currently does on
    multi-CD games with different resource bundles on difference CDs
    (Phant1, PQ:SWAT, GK2) because the resource manager does not yet
    have the ability to handle this situation.
    csnover committed Jun 22, 2016
  2. @Kirben
  3. @Kirben

    SCUMM HE: Document sound opcodes.

    Kirben committed Jun 22, 2016
Commits on Jun 21, 2016
  1. @csnover

    SCI32: Implement kBitmapDrawView

    csnover committed Jun 21, 2016
  2. @csnover

    SCI32: Expose a draw buffer on BitmapResource objects

    Most of the time, we get a bitmap to draw on it. Exposing a buffer
    avoids consumers having to create their own all the time, and
    encourages use of common drawing code exposed by the buffer.
    csnover committed Jun 21, 2016
  3. @sev-
  4. @csnover
  5. @csnover
  6. @csnover

    SCI: Add an explanation about LRU removals when fetching resources

    Several times I have run into this code and had to take a minute
    to remind myself that the call to remove from the LRU on find is
    not wrong, so it seemed to deserve a comment.
    csnover committed Jun 19, 2016
  7. @csnover

    SCI32: Fixes to GfxText32

    1. Inline borderSize constant in createFontBitmap for consistency
    2. Fix "DrawTextBox GetLongest=0" warning to only appear in games
       that actually had this check (SQ6 and MGDX)
    3. "Fix" implementation of getTextSize for SCI2.1early, which
       gave lines with word wrap disabled a height of 0
    4. Add inlining hints to some methods in BitmapResource that were
       missing them for some reason
    csnover committed Jun 18, 2016
  8. @csnover

    SCI32: Implement basic kMessageBox

    This kernel call seems only to be used by KQ7 1.51 (which was
    Windows-only) to send warnings to the user.
    It was easy enough to do a basic implementation in the ScummVM
    GUI rather than just make it an empty call, so now it is a thing.
    csnover committed Jun 18, 2016
  9. @wjp @csnover
  10. @wjp @csnover

    SCI32: Implement kScrollWindow

    These should be all the actually used subfunctions.
    Co-authored-by: Colin Snover <>
    wjp committed with csnover Mar 20, 2016
  11. @csnover

    SCI32: Implement line drawing (kAddLine/kUpdateLine/kRemoveLine)

    This line drawing code lives in a remodelled GfxPaint32 class
    that is totally separate from GfxPaint16.
    csnover committed Jun 18, 2016
  12. @wjp @csnover

    SCI32: Make GfxText32::_scaledWidth/Height statics

    They were global in SSCI. This way secondary GfxText32 instances
    (such as in ScrollWindow) use the correct scaling.
    wjp committed with csnover Mar 27, 2016
  13. @wjp @csnover
  14. @wjp @csnover
  15. @csnover

    SCI32: Add low-pass filter to 8-bit SOL audio

    This improves the perceived quality of audio in games that use
    8-bit samples for music, like Torin.
    csnover committed Jun 21, 2016
  16. @csnover
  17. @csnover

    SCI: Minor cleanup of kDoSound

    Replaces unused kernel calls to use kEmpty, and set correct
    signatures for SCI32 kernel calls.
    csnover committed Jun 11, 2016
  18. @csnover

    SCI32: Rewrite digital audio engine

    This provides a complete implementation of kDoAudio through
    SCI2.1mid, plus partial implementation of SCI3 features.
    Digital audio calls shunted through kDoSound have also been
    updated to go through the SCI32 audio mixer, though these shunts
    are a bit hacky because the ScummVM implementation of kDoSound
    does not currently match how SSCI kDoSound is designed.
    It is probably possible in the future to just replace the SCI1.1
    audio code (audio.cpp) with the new SCI32 code, since the major
    differences seem to be that (1) SCI1.1 only supported one digital
    audio playback channel (this is configurable already), (2) it
    had extra commands for CD audio playback and queued sample
    csnover committed Mar 18, 2016
Commits on Jun 19, 2016
  1. @csnover

    SCI: Split audio sync to its own class

    SCI32 has its own audio handling code, but audio sync code is the
    same as SCI16.
    csnover committed Jun 9, 2016
Something went wrong with that request. Please try again.