SCI: Workaround for uninit reads during wordsearch for castlebrain #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the wordsearch puzzle (room 320 click left door) the game will crash because of an uninitalized read of temp variables in word::dispatchEvent (which gets called a lot), if the player clicks the same letter or different letters aggressively. A workaround has been added to set all uninitalized temp variables to 0 in room 320 script 325 to prevent this crash. The index for the workaround was set to -1 to rather than 14 (temp var 14) because if just var 14 is fixed then temp var 15 will crash with an uninitialized read so there is atleast 2 uninitialized temp vars that are attempted to be read during this time leading to the bug. Fixes Trac#9783.
|
Thanks for the patch! This has landed in ec1cfcb. |
m-kiewitz
referenced
this pull request
Oct 7, 2017
During the wordsearch puzzle (room 320 click left door) the game will crash because of an uninitalized read of temp variables in word::dispatchEvent (which gets called a lot), if the player clicks the same letter or different letters aggressively or holds down the enter key. Fixes Trac#9783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the wordsearch puzzle (room 320 click left door) the
game will crash because of an uninitalized read of temp
variables in word::dispatchEvent (which gets called a lot),
if the player clicks the same letter or different letters
aggressively.
A workaround has been added to set all uninitalized temp variables
to 0 in room 320 script 325 to prevent this crash. The index for
the workaround was set to -1 to rather than 14 (temp var 14)
because if just var 14 is fixed then temp var 15 will crash with
an uninitialized read so there is atleast 2 uninitialized temp
vars that are attempted to be read during this time leading to
the bug.
Fixes Trac#9783.