COMPOSER: Remove leading dots from file paths read from book.ini #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
book.ini in the French version of Gregory has file paths with this format: '../data/page99.rsc'. According to the data structure described in bug #6548, removing the leading '../' should allow the engine to find the resource file in the data folder. Fixes #6548.
|
Actually, the game works well for me without this patch. With the patch the game asserts on:
|
|
...and the original bugreport is incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
book.ini in the French version of Gregory has file paths with this format: '../data/page99.rsc'.
According to the data structure described in bug #6548, removing the leading '../' should allow the engine to find the resource file where it is located, in the data folder.
I can't test this fix because I don't have the game. I would be glad if someone could test it or at least verify it does not break the other games.