SAGA: Deduplicate kScriptTimeTicksPerSecond constant #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying type of an enum cannot be a float so the following doesn't really make sense:
Because of that,
kScriptTimeTicksPerSecond
gets truncated to72
and is therefore identical tokScriptTimeTicksPerSecondIHNM
.This commit removes
kScriptTimeTicksPerSecondIHNM
, but if the engine actually requires a higher precision then this is not correct and the constant(s) need(s) to be made floating point.If it's OK to truncate I suggest adding a comment to the enum.