Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SCI: Update Sound:vol in processUpdateCues #1536
Sound:vol is updated when updating cues starting in SCI_VERSION_1_MIDDLE.
Fixes bug #10244. SQ4 localized floppy versions depend on this when getting
Confirmed against asm that this is not in SQ4 floppy (early) but is in
referenced this pull request
Apr 8, 2019
If it helps, the update cues function can be quickly found in most DOS SCI1 interpreters by the unique instruction:
and in mac interpreters:
The function ends with three consecutive calls to the set selector function prior to the change, afterwards there's a fourth for volume.
I'm going to merge this next week unless there's a reason not to.
That last one is so depressing it's a wonder I don't click merge right now.
My point is making sure that it's in every single SCI1 MIDDLE interpreter (Leusire Suit Larry 5 Demo, Conquests of the Longbow Demo, Leusire Suit Larry VGA Remake (2.0+2.1+EGA), , Astro Chicken 2, King's Quest 5 Japanese English FM-Towns) and definitely not in any SCI1 EARLY interpreter (King's Quest 5 Floppy versions, Leisure Suit Larry Demo, Mixed-Up Fairy Tales EGA+VGA, XMAS Card 1990 EGA+VGA, Space Quest 4 EGA+1.052+1.1 Floppy, Mixed-Up Mother Goose CD and Mixed-Up Mother Goose FM-Towns).
If you have checked all of these, then it's okay to commit.
If for example the change was done for the last few games that we consider SCI1 EARLY, then we would have to check on top if the game is accessing that selector at any point and making sure that not setting it will cause no issues. Because if it would, then we would have to add that specific game id too for your fix.
I don't understand. What's do depressing about a fix written in 2017?
I keep forgetting about this. Here are versions I've verified from ye olde notes:
Other than the Longbow demo, it cuts cleanly along the SCI_VERSION lines, and Longbow demo doesn't care either way since nothing in it depends on the vol property, which I tested.