Sword25: image trace on quick cursor changes fix #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on: DISTRIB_ID=ManjaroLinux |
|
Thanks! The dirty rects code was added when the engine was merged into ScummVM, so it’s good that you found the bug there, and tested the bugfix :) Please, fix spacing: the rest of the checks are split, one per line, so you should do the same with the new check, so that this pull request can be merged |
|
Done. I am glad to be of some help. |
|
Thanks for your work! Merging |
AndywinXp
added a commit
that referenced
this pull request
Jan 8, 2023
There was a nasty bug in the fuel tower room, when the cops arrive at the tower and the player regains control, in which the camera would be brought up and then down again. While I was there, since this is the same domain, I rechecked the v7-8 camera code from the disasm, made some corrections, and properly fixed #1195 and #1579. Another workaround bites the dust :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: https://bugs.scummvm.org/ticket/7061
Additional check in RenderObjectQueue::exists() that
checks if a RenderObject should be
redrawn.
After the change RenderObjectManager::render()
was tested to update 0 objects in the first active scene,
when player does nothing including not moving cursor
& 2 objects when player moves cursor.
It seems glitch happens when cursor image
changes from image X to image Y to image X in a short
time frame leaving image of state Y not re-rendered.