LURE: Enable the optional use of TTS to read descriptions as a narrator in "Lure of the Temptress" #1977
Conversation
…Lure of the Temptress
engines/lure/detection.cpp
Outdated
| @@ -73,7 +91,11 @@ static const LureGameDescription gameDescriptions[] = { | |||
| Common::EN_ANY, | |||
| Common::kPlatformDOS, | |||
| ADGF_NO_FLAGS, | |||
| #ifdef USE_TTS | |||
There was a problem hiding this comment.
The formatting is off in a lot of places - mixed spaces and tabs.
There was a problem hiding this comment.
It should be fixed. Thanks!
|
The commit text also isn't conforming to naming requirements.. it should have a "LURE: " in front of them. At this point, it would be a good idea for you to squash your branch into a single commit, and have it have the LURE: prefix |
|
I'm ok with squashing this PR as a single commit (same for #1953 ) |
engines/lure/surface.cpp
Outdated
| @@ -467,13 +472,31 @@ Surface *Surface::newDialog(uint16 width, uint8 numLines, const char **lines, bo | |||
|
|
|||
| Surface *s = new Surface(width, size.y); | |||
| s->createDialog(); | |||
| #ifdef USE_TTS | |||
| char *text = (char*) malloc(1024*sizeof(char)); | |||
| memset(text, 0, 1024); | |||
There was a problem hiding this comment.
Instead of using a char * here, you could use Common::String. The string manipulation code later on will be much easier and straightforward, and you won't need to have a hard limit of characters
|
It seems that one of the Travis CI tests from the latest commit failed fetching some packages. Can someone rerun it? |
|
Thanks for your work, and for fixing the remaining issues. I have requested a fresh Travis build and it worked fine. Merging |
LURE: Enable the optional use of TTS to read descriptions as a narrator in Lure of the Temptress
Added an option to use TTS to read descriptions in Lure of the Temptress.
Following the discussion in #1953, this option will only appear if the user
compiles with TTS support. It will read scene and object descriptions but
omit any character dialog.