Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURE: fix documentation for '--with-sdl-prefix' and indent subengines #2038

Merged
merged 2 commits into from Feb 19, 2020

Conversation

@ZvikaZ
Copy link
Contributor

ZvikaZ commented Feb 3, 2020

(I accidentally deleted PR #2033. These are the same commits)

  • CONFIGURE: fix documentation for --with-sdl-prefix flag
  • CONFIGURE: --help: indent subengines
    Instead of showing subengines directly under their parent engine, like:
	kyra                   Kyra engine
	lol                    Lands of Lore in Kyra engine
	eob                    Eye of the Beholder in Kyra engine
	lab                    Labyrinth of Time engine

Show them slightliy indented, like:

	kyra                   Kyra engine
	- lol                  Lands of Lore in Kyra engine
	- eob                  Eye of the Beholder in Kyra engine
	lab                    Labyrinth of Time engine

It keeps the list sorted, and makes it easier to skim through it.

ZvikaZ added 2 commits Feb 2, 2020
Instead of showing subengines directly under their parent engine, like:
	illusions              Illusions Engine engine
	kyra                   Kyra engine
	lol                    Lands of Lore in Kyra engine
	eob                    Eye of the Beholder in Kyra engine
	lab                    Labyrinth of Time engine

Show them slightliy indented, like:
    illusions              Illusions Engine engine
	kyra                   Kyra engine
	- lol                  Lands of Lore in Kyra engine
	- eob                  Eye of the Beholder in Kyra engine
	lab                    Labyrinth of Time engine

It keeps the list sorted, and makes it easier to skim through it.
@ZvikaZ ZvikaZ requested a review from bluegr Feb 12, 2020
@ZvikaZ

This comment has been minimized.

Copy link
Contributor Author

ZvikaZ commented Feb 18, 2020

Hi.
Can someone look at this?

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Feb 19, 2020

I like the changes. Thanks, merging

@sev- sev- merged commit e4473c0 into scummvm:master Feb 19, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.