Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Display a GUI error message when loading / saving failed #2043

Merged
merged 1 commit into from Feb 7, 2020

Conversation

@bgK
Copy link
Member

bgK commented Feb 5, 2020

Without this change, loading / saving fails silently (none of the callers check the return code).

@dreammaster

This comment has been minimized.

Copy link
Member

dreammaster commented Feb 5, 2020

Looks straightforward and good to me

@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Feb 6, 2020

Looks good to me too

@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Feb 7, 2020

As mentioned, this is quite a good and straightforward change, and the behavior introduced is correct.

Merging

@bluegr bluegr merged commit 35e0b72 into scummvm:master Feb 7, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bgK bgK deleted the bgK:engine-save-load-dialog-error-checking branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.