Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: Return unicode keycode for Hebrew input #2238

Merged
merged 1 commit into from May 12, 2020

Conversation

@ZvikaZ
Copy link
Contributor

ZvikaZ commented May 10, 2020

Before this commit, when typing in Hebrew, SDL reported the equivalent
English keycode. Thus, if user typed Hebrew letter Aleph, it was
reported as ascii of 't' (or 'T', I don't remember...).

It's still impossible to type Hebrew letters in the GUI's input dialogs,
but it's a step forward.

This was supposed to be part of a bigger PR, adding support for Hebrew in SQ3 (SCI0), but I'm waiting with this PR until there will be a decision in PR #2217. However, it's taking time, and I realized it might help @aryanrawlani28 's work on the GUI, and @BLooperZ 's work on other engines, therefore, it's submitted alone.

Before this commit, when typing in Hebrew, SDL reported the equivalent
English keycode. Thus, if user typed Hebrew letter Aleph, it was
reported as ascii of 't' (or 'T', I don't remember...).

It's still impossible to type Hebrew letters in the GUI's input dialogs,
but it's a step forward.
@sev-
Copy link
Member

sev- commented May 12, 2020

Thanks!

@sev- sev- merged commit 44c0b46 into scummvm:master May 12, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ZvikaZ ZvikaZ deleted the ZvikaZ:z_hebrew_input_unicode branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.