SDL: Return unicode keycode for Hebrew input #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, when typing in Hebrew, SDL reported the equivalent English keycode. Thus, if user typed Hebrew letter Aleph, it was reported as ascii of 't' (or 'T', I don't remember...). It's still impossible to type Hebrew letters in the GUI's input dialogs, but it's a step forward.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when typing in Hebrew, SDL reported the equivalent
English keycode. Thus, if user typed Hebrew letter Aleph, it was
reported as ascii of 't' (or 'T', I don't remember...).
It's still impossible to type Hebrew letters in the GUI's input dialogs,
but it's a step forward.
This was supposed to be part of a bigger PR, adding support for Hebrew in SQ3 (SCI0), but I'm waiting with this PR until there will be a decision in PR #2217. However, it's taking time, and I realized it might help @aryanrawlani28 's work on the GUI, and @BLooperZ 's work on other engines, therefore, it's submitted alone.